On 7/23/21 4:58 PM, Salvatore Daniele wrote: > match.c generates the keyword "igmp", which is not supported in ofp-parse. > This means that flow dumps containing 'igmp' can not be restored. > > Removing the 'igmp' keyword entirely could break existing scripts in stable > branches, so this patch creates a workaround within ovs-save by converting any > instances of "igmp" within $bridge.flows.dump into "ip, nw_proto=2". > > Signed-off-by: Salvatore Daniele <[email protected]> > Acked-by: Aaron Conole <[email protected]> > --- > utilities/ovs-save | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/utilities/ovs-save b/utilities/ovs-save > index 27ce3a9aa..23cb0d9d9 100755 > --- a/utilities/ovs-save > +++ b/utilities/ovs-save > @@ -150,7 +150,8 @@ save_flows () { > ovs-ofctl -O $ofp_version dump-flows --no-names --no-stats "$bridge" > | \ > sed -e '/NXST_FLOW/d' \ > -e '/OFPST_FLOW/d' \ > - -e 's/\(idle\|hard\)_age=[^,]*,//g' > \ > + -e 's/\(idle\|hard\)_age=[^,]*,//g' \ > + -e 's/igmp/ip,nw_proto=2/g' > \ > "$workdir/$bridge.flows.dump" > done > echo "rm -rf \"$workdir\"" >
Hmm. What about 'igmp_type' and 'igmp_code'? I don't think that OVS will be able to parse them. Should we replace them with generic 'tp_src' and 'tp_dst' ? Will that work? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
