This patch fixes a memory leak when the command
"dpif-netdev/subtable-lookup-prio-set" is run, the pmd_list
required to iterate the PMD threads was not being freed.
This issue was identified by a static analysis tool.

Fixes: 3d018c3e ("dpif-netdev: Add subtable lookup prio set command.")

Signed-off-by: Harry van Haaren <[email protected]>

---

Maintainers, please consider applying this patch to 2.14 and 2.15,
which are expected to have the same issue as fixed here.
---
 lib/dpif-netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 03f460c7d1..9e0d5c3103 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -994,6 +994,7 @@ dpif_netdev_subtable_lookup_set(struct unixctl_conn *conn, 
int argc OVS_UNUSED,
 
         /* release port mutex before netdev mutex. */
         ovs_mutex_unlock(&dp->port_mutex);
+        free(pmd_list);
     }
     ovs_mutex_unlock(&dp_netdev_mutex);
 
-- 
2.30.2

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to