> -----Original Message-----
> From: Stokes, Ian <[email protected]>
> Sent: Thursday 12 August 2021 15:43
> To: Ferriter, Cian <[email protected]>; [email protected]
> Cc: [email protected]
> Subject: RE: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document 
> subtable-lookup-* CMDs
> 
> > Fixes: 9ff7cabfd78d ("dpif-netdev: add subtable-lookup-prio-get command.")
> > Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.")
> > Signed-off-by: Cian Ferriter <[email protected]>
> 
> Thanks for the patch Cian. Can you add a one line summary to the commit 
> message above also?
> 

Added in the next version

> Few comments below.
> > ---
> >  lib/dpif-netdev-unixctl.man | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
> > index 80304ad35..c44c7eaa0 100644
> > --- a/lib/dpif-netdev-unixctl.man
> > +++ b/lib/dpif-netdev-unixctl.man
> > @@ -232,6 +232,16 @@ When this is the case, the above command prints the
> > load-balancing information
> >  of the bonds configured in datapath \fIdp\fR showing the interface 
> > associated
> >  with each bucket (hash).
> >  .
> > +.IP "\fBdpif-netdev/subtable-lookup-prio-get\fR"
> > +Lists the DPCLS implementations or lookup functions that are available as 
> > well
> > +as their priorities.
> > +.
> > +.IP "\fBdpif-netdev/subtable-lookup-prio-set\fR \fIlookup_function\fR \
> > +\fIprio\fR"
> > +Sets the priority of a lookup function by name, \fIlookup_function\fR, and
> > +priority, \fIprio\fR, which should be a positive integer value.  The 
> > highest
> > +priority lookup function is used for classification.
> 
> Is it worth mentioning that the number of dpcls ports and subtables affected 
> are returned?
> 

Added in the next version

> 
> BR
> Ian

Thanks for the review Ian.

> > +.
> >  .IP "\fBdpif-netdev/dpif-impl-get\fR
> >  Lists the DPIF implementations that are available.
> >  .
> > --
> > 2.32.0
> >
> > _______________________________________________
> > dev mailing list
> > [email protected]
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to