On 5 Aug 2021, at 21:47, Paolo Valerio wrote:

> Eelco Chaudron <[email protected]> writes:
>
>> This patch adds a general way of viewing/configuring datapath
>> cache sizes. With an implementation for the netlink interface.
>>
>> The ovs-dpctl/ovs-appctl show commands will display the
>> current cache sizes configured:
>>
>> ovs-dpctl show
>> system@ovs-system:
>>   lookups: hit:25 missed:63 lost:0
>>   flows: 0
>>   masks: hit:282 total:0 hit/pkt:3.20
>>   cache: hit:4 hit rate:4.54%
>>   caches:
>>     masks-cache: size: 256
>>   port 0: ovs-system (internal)
>>   port 1: br-int (internal)
>>   port 2: genev_sys_6081 (geneve: packet_type=ptap)
>>   port 3: br-ex (internal)
>>   port 4: eth2
>>   port 5: sw0p1 (internal)
>>   port 6: sw0p3 (internal)
>>
>> A specific cache can be configured as follows:
>>
>> ovs-appctl dpctl/cache-set-size DP CACHE SIZE
>> ovs-dpctl cache-set-size DP CACHE SIZE
>>
>> For example to disable the cache do:
>>
>> $ ovs-dpctl cache-set-size system@ovs-system masks-cache 0
>> Setting cache size successful, new size 0.
>>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>>
>> ---
>> v2: - Changed precision to 2 digits
>>     - Handle missing kernel feature at netlink level
>> v3: - Rebase on the latest master branch
>> v4: - Fixed commit message
>>     - Fix issue with resetting user_features
>> v5: - Include the actual resetting user_features fix
>
> Hi Eelco,
>
> thanks for including the user_feautes fix.
>
> The patch looks good to me, and I tested it successfully.
> It just needs a rebase.
> Other than that,
>
> Acked-by: Paolo Valerio <[email protected]>

Thanks for the review! Ilya     do you want a new version with the rebase?

//Eelco

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to