Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#40 FILE: northd/ovn-northd.c:4312:
static void ovn_lflow_destroy(struct lflow_state *lflows, struct ovn_lflow
*lflow);
WARNING: Line is 90 characters long (recommended limit is 79)
#65 FILE: northd/ovn-northd.c:4388:
old_lflow = do_ovn_lflow_find(&lflow_map->single_od, NULL, stage,
priority, match,
WARNING: Line is 91 characters long (recommended limit is 79)
#73 FILE: northd/ovn-northd.c:4396:
hmap_insert_fast(&lflow_map->multiple_od,
&old_lflow->hmap_node, hash);
WARNING: Line is 86 characters long (recommended limit is 79)
#75 FILE: northd/ovn-northd.c:4398:
hmap_insert(&lflow_map->multiple_od, &old_lflow->hmap_node,
hash);
WARNING: Line is 96 characters long (recommended limit is 79)
#80 FILE: northd/ovn-northd.c:4403:
old_lflow = do_ovn_lflow_find(&lflow_map->multiple_od, NULL, stage,
priority, match,
WARNING: Line is 82 characters long (recommended limit is 79)
#147 FILE: northd/ovn-northd.c:4525:
do_ovn_lflow_find(&lflows->single_od, od, stage, priority, match,
actions,
WARNING: Line is 83 characters long (recommended limit is 79)
#150 FILE: northd/ovn-northd.c:4528:
lflow = do_ovn_lflow_find(&lflows->multiple_od, od, stage, priority,
match,
WARNING: Line is 84 characters long (recommended limit is 79)
#615 FILE: northd/ovn-northd.c:8429:
build_ecmp_routing_policy_flows(struct lflow_state *lflows, struct ovn_datapath
*od,
WARNING: Line is 80 characters long (recommended limit is 79)
#669 FILE: northd/ovn-northd.c:9430:
build_lswitch_flows_for_lb(struct ovn_northd_lb *lb, struct lflow_state *lflows,
WARNING: Line is 80 characters long (recommended limit is 79)
#687 FILE: northd/ovn-northd.c:9527:
build_lrouter_flows_for_lb(struct ovn_northd_lb *lb, struct lflow_state *lflows,
WARNING: Line is 83 characters long (recommended limit is 79)
#750 FILE: northd/ovn-northd.c:9996:
build_lrouter_force_snat_flows(struct lflow_state *lflows, struct ovn_datapath
*od,
WARNING: Line is 82 characters long (recommended limit is 79)
#822 FILE: northd/ovn-northd.c:10518:
build_ND_RA_flows_for_lrouter(struct ovn_datapath *od, struct lflow_state
*lflows)
WARNING: Line is 86 characters long (recommended limit is 79)
#876 FILE: northd/ovn-northd.c:10765:
routable_addresses_to_lflows(struct lflow_state *lflows, struct ovn_port
*router_port,
WARNING: Line is 85 characters long (recommended limit is 79)
#894 FILE: northd/ovn-northd.c:11129:
build_icmperr_pkt_big_flows(struct ovn_port *op, int mtu, struct lflow_state
*lflows,
WARNING: Line is 81 characters long (recommended limit is 79)
#903 FILE: northd/ovn-northd.c:11222:
struct lflow_state *lflows, struct hmap
*ports,
WARNING: Line is 81 characters long (recommended limit is 79)
#993 FILE: northd/ovn-northd.c:12043:
build_lrouter_in_unsnat_flow(struct lflow_state *lflows, struct ovn_datapath
*od,
WARNING: Line is 82 characters long (recommended limit is 79)
#1011 FILE: northd/ovn-northd.c:12193:
build_lrouter_out_undnat_flow(struct lflow_state *lflows, struct ovn_datapath
*od,
WARNING: Line is 80 characters long (recommended limit is 79)
#1020 FILE: northd/ovn-northd.c:12240:
build_lrouter_out_snat_flow(struct lflow_state *lflows, struct ovn_datapath *od,
WARNING: Line is 84 characters long (recommended limit is 79)
#1038 FILE: northd/ovn-northd.c:12469:
build_lrouter_nat_defrag_and_lb(struct ovn_datapath *od, struct lflow_state
*lflows,
WARNING: Line is 85 characters long (recommended limit is 79)
#1085 FILE: northd/ovn-northd.c:12937:
struct hmap *port_groups, struct lflow_state
*lflows,
WARNING: Line is 85 characters long (recommended limit is 79)
#1103 FILE: northd/ovn-northd.c:12973:
fast_hmap_init(&lflow_segs[index].single_od,
lflows->single_od.mask);
WARNING: Line is 80 characters long (recommended limit is 79)
#1114 FILE: northd/ovn-northd.c:12998:
&lflows->single_od, lflow_segs, lflow_merge_callback);
Lines checked: 1354, Warnings: 22, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
