I agree this should be the default.
Acked-by: Mark Michelson <[email protected]>
On 8/20/21 5:08 PM, [email protected] wrote:
From: Numan Siddique <[email protected]>
Support for logical dp group is present since more than
2 releases now and its time to enable it as a default.
Signed-off-by: Numan Siddique <[email protected]>
---
NEWS | 2 ++
northd/ovn-northd.c | 2 +-
northd/ovn_northd.dl | 2 +-
tests/ovn-macros.at | 2 ++
4 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 606ec6c77..6da59410d 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ Post-v21.06.0
- Introduced a new "label" field for "allow" and "allow-related" ACLs
which helps in debugging/backtracking the ACL which allowed a particular
connection.
+ - Enabled logical dp groups as a default. CMS should disable it if not
+ desired.
OVN v21.06.0 - 18 Jun 2021
-------------------------
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 3d8e21a4f..da443615e 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -14079,7 +14079,7 @@ ovnnb_db_run(struct northd_context *ctx,
can_parallelize_hashes(false));
use_logical_dp_groups = smap_get_bool(&nb->options,
- "use_logical_dp_groups", false);
+ "use_logical_dp_groups", true);
use_ct_inv_match = smap_get_bool(&nb->options,
"use_ct_inv_match", true);
diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl
index 9cf4c373b..7e21af093 100644
--- a/northd/ovn_northd.dl
+++ b/northd/ovn_northd.dl
@@ -1687,7 +1687,7 @@ function stage_hint(_uuid: uuid): bit<32> {
relation UseLogicalDatapathGroups[bool]
UseLogicalDatapathGroups[use_logical_dp_groups] :-
nb in nb::NB_Global(),
- var use_logical_dp_groups =
nb.options.get_bool_def("use_logical_dp_groups", false).
+ var use_logical_dp_groups =
nb.options.get_bool_def("use_logical_dp_groups", true).
UseLogicalDatapathGroups[false] :-
Unit(),
not nb in nb::NB_Global().
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
index b5a01b2b5..f06f2e68e 100644
--- a/tests/ovn-macros.at
+++ b/tests/ovn-macros.at
@@ -249,6 +249,8 @@ ovn_start () {
if test X$NORTHD_USE_DP_GROUPS = Xyes; then
ovn-nbctl set NB_Global . options:use_logical_dp_groups=true
+ else
+ ovn-nbctl set NB_Global . options:use_logical_dp_groups=false
fi
if test X$NORTHD_USE_PARALLELIZATION = Xyes; then
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
