Hi Mark,
I had a look at this series, but I'm not 100% sure what the intent is.
In patch 2, you mentioned modularity and the ability to include northd
as a library. But I'm not sure where that allows us to go. Can you
elaborate a bit?
Thanks,
Mark
On 8/26/21 3:04 PM, Mark Gray wrote:
Please note that this commit mainly involves moving code around with minimal
code changes. However, due to tight coupling between ovn-northd.c and northd.c,
some minor changes were needed. For reference, and to help reviews, please
examine the following at a minimum:
* Configuration of the probe interval in northd.c
(ovsdb_idl_set_probe_interval())
* Passing of "use_parallel_build" and "lflow_locks" from ovn-northd.c and
northd.c.
* Update of "struct northd_context": additopn of fields and move to h file.
The commits were (hopefully) structured in a way to make the review easier. As
this change touches all of ovn-northd, any change to "master" will make a rebase
necessary and probably difficult. Therefore, if the general ideas is OK, then
it would be great if this series could be expedited to prevent many rebases!
Thanks
Mark Gray (2):
ovn-northd: Rename ovn-northd.c to northd.c
northd: Split northd.c
Documentation/tutorials/ovn-openstack.rst | 154 +-
northd/automake.mk | 2 +
northd/lrouter.dl | 2 +-
northd/northd.c | 14418 +++++++++++++++++++
northd/northd.h | 42 +
northd/ovn-northd.c | 14717 +-------------------
northd/ovn.rs | 2 +-
northd/ovn_northd.dl | 2 +-
tests/ovn-northd.at | 2 +-
9 files changed, 14709 insertions(+), 14632 deletions(-)
create mode 100644 northd/northd.c
create mode 100644 northd/northd.h
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
