Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 91 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#61 FILE: northd/ovn-northd.c:4404:
* See if we can get away without writing - grab a rdlock and check if we
can get away
WARNING: Line is 81 characters long (recommended limit is 79)
#77 FILE: northd/ovn-northd.c:4416:
/* od not in od_group, we need to add it and move to multiple.
*/
WARNING: Line is 81 characters long (recommended limit is 79)
#82 FILE: northd/ovn-northd.c:4418:
/* Upgrade the lock to write, we are likely to modify data
*/
WARNING: Line is 87 characters long (recommended limit is 79)
#90 FILE: northd/ovn-northd.c:4426:
if (!hmap_contains(&lflow_map->single_od,
&old_lflow->hmap_node)) {
WARNING: Line has trailing whitespace
#96 FILE: northd/ovn-northd.c:4432:
ovn_make_multi_lflow(old_lflow, od, lflow_map, hash);
WARNING: Line is 80 characters long (recommended limit is 79)
#148 FILE: northd/ovn-northd.c:4470:
/* While adding new logical flows we're not setting single datapath, but
WARNING: Line is 82 characters long (recommended limit is 79)
#149 FILE: northd/ovn-northd.c:4471:
* collecting a group. 'od' will be updated later for all flows with
only
WARNING: Line is 94 characters long (recommended limit is 79)
#161 FILE: northd/ovn-northd.c:4483:
old_lflow = do_ovn_lflow_find(&lflow_map->single_od, NULL, stage,
priority, match,
WARNING: Line has trailing whitespace
#165 FILE: northd/ovn-northd.c:4487:
ovn_make_multi_lflow(old_lflow, od, lflow_map, hash);
WARNING: Line is 86 characters long (recommended limit is 79)
#169 FILE: northd/ovn-northd.c:4491:
/* Unlikely, but possible, more than one thread got here ahead of
us while
WARNING: Line is 96 characters long (recommended limit is 79)
#171 FILE: northd/ovn-northd.c:4493:
old_lflow = do_ovn_lflow_find(&lflow_map->multiple_od, NULL, stage,
priority, match,
WARNING: Line is 80 characters long (recommended limit is 79)
#179 FILE: northd/ovn-northd.c:4501:
/* While adding new logical flows we're not setting single datapath, but
WARNING: Line is 82 characters long (recommended limit is 79)
#180 FILE: northd/ovn-northd.c:4502:
* collecting a group. 'od' will be updated later for all flows with
only
Lines checked: 271, Warnings: 14, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
