On Fri, Aug 27, 2021 at 2:42 PM Flavio Fernandes <[email protected]> wrote: > > > This revert does not include a 1 liner change needed done later in > https://github.com/ovn-org/ovn/commit/4e6c498068dc4fa9546d3661f78f0a42e99c74bb > > <https://github.com/ovn-org/ovn/commit/4e6c498068dc4fa9546d3661f78f0a42e99c74bb> > That is not an issue, since regex change there is backwards compatible, agree? > > > Acked-by: Flavio Fernandes <[email protected]> > > > > On Aug 27, 2021, at 11:29 AM, Mark Michelson <[email protected]> wrote: > > > > This commit resulted in significant decreased dataplane performance when > > testing a dense OpenShift cluster. This was pinpointed to be due to an > > extra ct(nat(src)) that this commit added. > > > > For now, revert this commit. > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1992012 > > Signed-off-by: Mark Michelson <[email protected]>
Should we revert this patch too - ? Dumitru added these patches as part of this series - https://patchwork.ozlabs.org/project/ovn/list/?series=248327&state=* And you are reverting the patch 5 of the series I think. Does it also makes sense to revert patch 4 (which is this commit https://github.com/ovn-org/ovn/commit/56e2cd3a2f06b79b7d57cc8637fc0d258652aff5) too ? Reverting patch 4 would unblock the OVN upgrades where the older version (ovs 2.11) is used. We can add back patch 4 and probably patch 5 after we figure out the root cause of the datapath performance issue. Or limit ct(snat(src)) only for TCP. Thanks Numan > > --- > > include/ovn/actions.h | 1 - > > lib/actions.c | 31 ------ > > tests/ovn.at | 2 +- > > tests/system-common-macros.at | 4 - > > tests/system-ovn.at | 190 ---------------------------------- > > 5 files changed, 1 insertion(+), 227 deletions(-) > > > ... > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
