On 8/24/21 9:00 PM, Ilya Maximets wrote: > In short, database snapshot stored inside the raft module is > a huge json object. E.g. in ovn-heater scale tests with 270 MB > on-disk Southbound DB, json object of a snapshot takes 1.6 GB of > RAM out of total 3.8 GB of the RSS of an ovsdb-server process. > > Second patch of the set is targeted to free that json object as > soon as it no longer needed and keep its serialized version instead. > First patch provides required json infrastructure. > > Testing on a bit smaller cluster with 97 MB of on-disk database > showed *58%* of the memory consumption decrease with this change. > Testing with 270 MB database showed RSS decrease by 1.5 GB. > > The third patch re-uses same json infrastructure to significantly > reduce CPU time by pre-serializing json cache. > > All changes applied allowed to reduce CPU time by 50% and memory > consumption by 1.5G on 120 node density-heavy test with ovn-heater. > Duration of long poll intervals on Southbound database dropped > from 7.5 to 2 seconds.
This is great! > > More details on testing and implementation in commit messages. The patch series looks good to me, I just had some minor comments that can be dealt with at apply time. Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
