Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1257 FILE: northd/northd.c:14664:
ERROR: Improper whitespace around control block
#1689 FILE: northd/ovn-northd.c:378:
SBREC_DHCP_OPTIONS_FOR_EACH_SAFE(opt_row, opt_row_next, ctx->ovnsb_idl) {
ERROR: Improper whitespace around control block
#1738 FILE: northd/ovn-northd.c:427:
HMAP_FOR_EACH(opt, hmap_node, &dhcpv6_opts_to_add) {
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1758 FILE: northd/ovn-northd.c:447:
--ovnnb-db=DATABASE connect to ovn-nb database at DATABASE\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1760 FILE: northd/ovn-northd.c:449:
--ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\
WARNING: Line lacks whitespace around operator
#1762 FILE: northd/ovn-northd.c:451:
--dry-run start in paused state (do not commit db changes)\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1763 FILE: northd/ovn-northd.c:452:
--unixctl=SOCKET override default control socket name\n\
Lines checked: 2416, Warnings: 11, Errors: 2
build:
libtool: link: gcc -std=gnu99 -Wstrict-prototypes -Wall -Wextra
-Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
-Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
-Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
-fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -o
controller-vtep/ovn-controller-vtep controller-vtep/binding.o
controller-vtep/gateway.o controller-vtep/ovn-controller-vtep.o
controller-vtep/vtep.o lib/.libs/libovn.a
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib/.libs/libopenvswitch.a
-lssl -lcrypto -lcap-ng
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/vtep/.libs/libvtep.a
-lpthread -lrt -lm -lunbound
depbase=`echo northd/northd.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I
./include -I ./lib -I ./lib -I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
-I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
-I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
-I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
-I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR -I
/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
-Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat
-Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast
-Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT northd/northd.o -MD -MP -MF $depbase.Tpo -c -o northd/northd.o
northd/northd.c &&\
mv -f $depbase.Tpo $depbase.Po
northd/northd.c: In function ‘ovn_lflow_add_at_with_hash’:
northd/northd.c:4355:9: error: passing argument 1 of ‘lock_hash_row’ from
incompatible pointer type [-Werror]
lock_hash_row(&lflow_locks, hash);
^
In file included from northd/northd.h:18:0,
from northd/northd.c:39:
./lib/ovn-parallel-hmap.h:236:20: note: expected ‘struct hashrow_locks *’ but
argument is of type ‘struct hashrow_locks **’
static inline void lock_hash_row(struct hashrow_locks *hrl, uint32_t hash)
^
northd/northd.c:4359:9: error: passing argument 1 of ‘unlock_hash_row’ from
incompatible pointer type [-Werror]
unlock_hash_row(&lflow_locks, hash);
^
In file included from northd/northd.h:18:0,
from northd/northd.c:39:
./lib/ovn-parallel-hmap.h:242:20: note: expected ‘struct hashrow_locks *’ but
argument is of type ‘struct hashrow_locks **’
static inline void unlock_hash_row(struct hashrow_locks *hrl, uint32_t hash)
^
cc1: all warnings being treated as errors
make[1]: *** [northd/northd.o] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
