> -----Original Message----- > From: Kevin Traynor [mailto:[email protected]] > Sent: Wednesday, September 1, 2021 8:28 PM > To: wangyunjian <[email protected]>; [email protected]; > [email protected] > Cc: dingxiaoxiong <[email protected]> > Subject: Re: [ovs-dev] [PATCH] bond: Fix return value check in > bond_member_set_may_enable() > > On 01/09/2021 10:43, Yunjian Wang wrote: > > For title, how about: > > "bond: Check for NULL member in bond_member_set_enable()." > > > The function bond_member_lookup() could return NULL, the return value > > need to be checked. > > > > Addresses-Coverity: ("Dereference null return value") > > This is not a typical tag in OVS. If if it is from a private coverity run, > you can just > mention it was found by coverity. If it is public you can use the the > "Reported-at: > <link to coverity issue>". > > Fix itself looks good, thanks. With commit msg changes, > Acked-by: Kevin Traynor <[email protected]>
Thanks for the suggestion. V2 has been sent. http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ > > > Signed-off-by: Yunjian Wang <[email protected]> > > --- > > ofproto/bond.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/ofproto/bond.c b/ofproto/bond.c index > > a4116588f..2dcfeda71 100644 > > --- a/ofproto/bond.c > > +++ b/ofproto/bond.c > > @@ -672,8 +672,13 @@ out: > > void > > bond_member_set_may_enable(struct bond *bond, void *member_, bool > > may_enable) { > > + struct bond_member *member; > > + > > ovs_rwlock_wrlock(&rwlock); > > - bond_member_lookup(bond, member_)->may_enable = may_enable; > > + member = bond_member_lookup(bond, member_); > > + if (member) { > > + member->may_enable = may_enable; > > + } > > ovs_rwlock_unlock(&rwlock); > > } > > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
