On 27/08/2021 16:15, Cian Ferriter wrote: > Directly copying the CMD from either the .rst file or the docs on the > web caused errors in the QEMU command because of how it was wrapped. > > Signed-off-by: Cian Ferriter <[email protected]> >
Acked-by: Kevin Traynor <[email protected]> In general, it would be nice to replace all the qemu command line snippets with libvirt xml. As someone once told me, "normal people use libvirt" :-) > --- > > The CMD could be wrapped, but without the indentation to look like this: > qemu-system-x86_64 -hda ubuntu1810.qcow \ > -m 4096 \ > -cpu host,+x2apic -enable-kvm \ > -chardev socket,id=char1,path=/usr/local/var/run/openvswitch/vhost-user-1 \ > -netdev type=vhost-user,id=mynet1,chardev=char1,vhostforce,queues=4 \ > -device virtio-net-pci,mac=00:00:00:00:00:01,\ > netdev=mynet1,mq=on,vectors=10 \ > -object memory-backend-file,id=mem,size=4096M,\ > mem-path=/dev/hugepages,share=on \ > -numa node,memdev=mem -mem-prealloc -smp 2 > > But I went with the below, which has lines that extend past 79 characters. > qemu-system-x86_64 -hda ubuntu1810.qcow \ > -m 4096 \ > -cpu host,+x2apic -enable-kvm \ > -chardev socket,id=char1,path=/usr/local/var/run/openvswitch/vhost-user-1 \ > -netdev type=vhost-user,id=mynet1,chardev=char1,vhostforce,queues=4 \ > -device > virtio-net-pci,mac=00:00:00:00:00:01,netdev=mynet1,mq=on,vectors=10 \ > -object > memory-backend-file,id=mem,size=4096M,mem-path=/dev/hugepages,share=on \ > -numa node,memdev=mem -mem-prealloc -smp 2 > --- > Documentation/intro/install/afxdp.rst | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/Documentation/intro/install/afxdp.rst > b/Documentation/intro/install/afxdp.rst > index f2643e0d4..47149cc73 100644 > --- a/Documentation/intro/install/afxdp.rst > +++ b/Documentation/intro/install/afxdp.rst > @@ -374,11 +374,9 @@ Start a VM with virtio and tap device:: > qemu-system-x86_64 -hda ubuntu1810.qcow \ > -m 4096 \ > -cpu host,+x2apic -enable-kvm \ > - -device virtio-net-pci,mac=00:02:00:00:00:01,netdev=net0,mq=on,\ > - vectors=10,mrg_rxbuf=on,rx_queue_size=1024 \ > + -device > virtio-net-pci,mac=00:02:00:00:00:01,netdev=net0,mq=on,vectors=10,mrg_rxbuf=on,rx_queue_size=1024 > \ > -netdev type=tap,id=net0,vhost=on,queues=8 \ > - -object memory-backend-file,id=mem,size=4096M,\ > - mem-path=/dev/hugepages,share=on \ > + -object > memory-backend-file,id=mem,size=4096M,mem-path=/dev/hugepages,share=on \ > -numa node,memdev=mem -mem-prealloc -smp 2 > > Create OpenFlow rules:: > @@ -415,10 +413,8 @@ Start VM using vhost-user mode:: > -cpu host,+x2apic -enable-kvm \ > -chardev socket,id=char1,path=/usr/local/var/run/openvswitch/vhost-user-1 > \ > -netdev type=vhost-user,id=mynet1,chardev=char1,vhostforce,queues=4 \ > - -device virtio-net-pci,mac=00:00:00:00:00:01,\ > - netdev=mynet1,mq=on,vectors=10 \ > - -object memory-backend-file,id=mem,size=4096M,\ > - mem-path=/dev/hugepages,share=on \ > + -device > virtio-net-pci,mac=00:00:00:00:00:01,netdev=mynet1,mq=on,vectors=10 \ > + -object > memory-backend-file,id=mem,size=4096M,mem-path=/dev/hugepages,share=on \ > -numa node,memdev=mem -mem-prealloc -smp 2 > > Setup the OpenFlow ruls:: > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
