Hi Dumitru,
Thanks for the review:)
On 9/21/21 5:14 PM, Dumitru Ceara wrote:
On 9/20/21 3:20 PM, [email protected] wrote:
From: Mohammad Heib <[email protected]>
currently ovn-northd only handle virtual ports with VIP IPv4 and ignores
virtual ports with VIP IPv6.
This patch adds support for virtual ports with VIP IPv6 by adding
lflows to the lsp_in_arp_rsp logical switch pipeline.
Those lflows handle Neighbor Solicitations and Neighbor Advertisement requests
that target the virtual port VIPs and bind the virtual port to the desired VIF.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2003091
Fixes: 054f4c85c413 ("Add a new logical switch port type - 'virtual'")
Signed-off-by: Mohammad Heib <[email protected]>
---
Hi Mohammad,
Thanks for the patch!
This is not a full review yet, just some stuff I noticed while glancing
over the patch.
It would be great if you could add a test case in ovn-northd.at to make
sure the logical flows are generated as expected. This would also
ensure that we don't miss adding the northd-ddlog part (which is not
present in this patch).
i submitted patch v2 [1] that adds some test cases for vip with ipv6,
there is a test that targets virtual port
with ipv4 i added some cases to this test to cover virtual port with
ipv6 vip.
[1]
http://patchwork.ozlabs.org/project/ovn/patch/[email protected]/
northd/northd.c | 52 +++++++++++++++++++++++++++++++++++++++----------
1 file changed, 42 insertions(+), 10 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index d1b87891c..d85036dcc 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -7386,16 +7386,30 @@ build_lswitch_arp_nd_responder_known_ips(struct
ovn_port *op,
* - ARP reply from the virtual ip which belongs to a logical
* port of type 'virtual' and bind that port.
* */
- ovs_be32 ip;
+
+ union ip {
+ ovs_be32 ip;
+ ovs_u128 ipv6;
+ }ip;
+
I think we should probably use in6_add and in6_addr_mapped_ipv4 instead
of coming up with a new type.
thanks, the v2 patch use the in6_add instead of adding new type.
Regards,
Dumitru
thanks,
Mohammad
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
