On Tue, Sep 28, 2021 at 02:41:17PM +0800, Chris Mi wrote: > Hi Simon, > > On 9/24/2021 3:03 PM, Simon Horman wrote: > > On Thu, Sep 16, 2021 at 11:38:52AM +0300, Chris Mi wrote: > > > Add two sFlow offload test caes: > > > > > > 3: sflow offloads with sampling=1 - ping between two ports - offloads > > > enabled ok > > > 4: sflow offloads with sampling=2 - ping between two ports - offloads > > > enabled ok > > > > > > Signed-off-by: Chris Mi<[email protected]> > > Thanks Chris, > > > > These tests look good to me. But could we arrange things such > > that they are skipped if the system doesn't support this offload. > Above 2 new tests don't have special requirement. They take test case #2 as > example and extend it. > You know the sample offload series is being reviewed in another email > thread. Maybe I should add this > patch to the end of that series. There are two reasons I didn't add it: > 1. I don't want to increase the version number too big. > 2. It is easier to review and revise this patch alone. > > So how about I add this patch to the sample offload series in next version? > Then we don't need to check > if the system support it or not. Because if it fails in the future, we must > fix it.
Thanks, I think that is reasonable. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
