On 9/16/21 21:39, David Marchand wrote: > On Thu, Sep 16, 2021 at 8:11 AM Sunil Pai G <[email protected]> wrote: >> >> The DPDK component defines have been renamed from >> RTE_LIBRTE_* to macro's of the form: >> "RTE_" + <class> + "_" + drivername >> as documented in the commit [1]. > > Nit: for clarity, "in the DPDK commit [1]." > >> This commit replaces the old macro's with new ones. > > Nit: "This commit" is ambiguous when read after the first sentence. > I'd go with a simple: "Replace the old macros with new form", or "Use > the new form of macros". > >> >> Macro's changed: >> OLD NEW >> --------- ---------- >> RTE_LIBRTE_PMD_PCAP --> RTE_NET_PCAP >> RTE_LIBRTE_PMD_AF_XDP --> RTE_NET_AF_XDP >> RTE_LIBRTE_MLX5_PMD --> RTE_NET_MLX5 >> RTE_LIBRTE_MLX4_PMD --> RTE_NET_MLX4 >> >> [1]: 762bfccc8abf ("config: remove compatibility build defines") >> >> Signed-off-by: Sunil Pai G <[email protected]> > > Those two nits can be fixed when applying. > Reviewed-by: David Marchand <[email protected]> > > Thanks. > >
Thanks! I updated the commit message and applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
