On 10/14/21 23:18, Toms Atteka wrote: > This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and > packets can be filtered using ipv6_ext flag. > > Signed-off-by: Toms Atteka <[email protected]> > --- > include/uapi/linux/openvswitch.h | 16 +++- > net/openvswitch/flow.c | 140 +++++++++++++++++++++++++++++++ > net/openvswitch/flow.h | 14 ++++ > net/openvswitch/flow_netlink.c | 24 +++++- > 4 files changed, 192 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/openvswitch.h > b/include/uapi/linux/openvswitch.h > index a87b44cd5590..763adf3dce23 100644 > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -344,8 +344,17 @@ enum ovs_key_attr { > OVS_KEY_ATTR_NSH, /* Nested set of ovs_nsh_key_* */ > > #ifdef __KERNEL__ > - OVS_KEY_ATTR_TUNNEL_INFO, /* struct ip_tunnel_info */ > + OVS_KEY_ATTR_TUNNEL_INFO,/* struct ip_tunnel_info */ > + __OVS_KEY_ATTR_PADDING_1,/* Padding to match field count with ovs */ > #endif > + > +#ifndef __KERNEL__ > + __OVS_KEY_ATTR_PADDING_2,/* Padding to match field count with ovs */ > + __OVS_KEY_ATTR_PADDING_3,/* Padding to match field count with ovs */ > +#endif > + > + OVS_KEY_ATTR_IPV6_EXTHDRS, /* struct ovs_key_ipv6_exthdr */ > + > __OVS_KEY_ATTR_MAX > };
Not a full review, but, I think, that we should not add paddings, and define OVS_KEY_ATTR_IPV6_EXTHDRS before the OVS_KEY_ATTR_TUNNEL_INFO instead. See my comments for v6: https://lore.kernel.org/netdev/[email protected]/T/#u Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
