On 10/14/21 5:17 PM, Lorenzo Bianconi wrote: [...]
> diff --git a/controller/local_data.h b/controller/local_data.h > index f6317e9ca..3defa9925 100644 > --- a/controller/local_data.h > +++ b/controller/local_data.h > @@ -154,5 +154,12 @@ bool get_chassis_tunnel_ofport(const struct hmap > *chassis_tunnels, > ofp_port_t *ofport); > > void chassis_tunnels_destroy(struct hmap *chassis_tunnels); > +void local_datapath_memory_usage(struct simap *usage); > +void > +add_local_datapath_external_port(struct local_datapath *ld, > + char *logical_port, const void *data); Probably best to change this to 'const char *logical_port'. When reviewing I was in doubt about whether we should free the shash_node's data when removing external_ports. Changing the type to const would make it explicit, as free works only on non-const pointers. > +void > +remove_local_datapath_external_port(struct local_datapath *ld, > + char *logical_port); Same here. Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
