Flavio Leitner <f...@sysclose.org> writes:
> On Thu, Oct 07, 2021 at 02:35:40PM +0200, Paolo Valerio wrote:
>> Tests for both ipv4 and ipv6 have been added.
>
> Thanks for writing the unit tests.
> Could you please add them as part of the patch adding the commands?
>
Thank you for looking at this series.
Ok, I'll drop this patch and add the tests to the relevant patches.
Paolo
> Thanks
> fbl
>
>>
>> Signed-off-by: Paolo Valerio <pvale...@redhat.com>
>> ---
>> tests/tunnel-push-pop-ipv6.at | 66
>> +++++++++++++++++++++++++++++++++++++++++
>> tests/tunnel-push-pop.at | 65
>> ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 131 insertions(+)
>>
>> diff --git a/tests/tunnel-push-pop-ipv6.at b/tests/tunnel-push-pop-ipv6.at
>> index 59723e63b..5c4dd248b 100644
>> --- a/tests/tunnel-push-pop-ipv6.at
>> +++ b/tests/tunnel-push-pop-ipv6.at
>> @@ -255,6 +255,36 @@ AT_CHECK([cat p0.pcap.txt | grep
>> 93aa55aa55000086dd6000000000203aff2001cafe | un
>>
>> 3333ff000093aa55aa55000086dd6000000000203aff2001cafe000000000000000000000088ff0200000000000000000001ff00009387004d46000000002001cafe0000000000000000000000930101aa55aa550000
>> ])
>>
>> +dnl Set the ageing time to 5 seconds
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing 5], [0], [OK
>> +])
>> +
>> +dnl Read the current ageing time
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing], [0], [5
>> +])
>> +
>> +dnl Add an entry
>> +AT_CHECK([ovs-appctl tnl/neigh/set br0 2001:cafe::92 aa:bb:cc:00:00:01],
>> [0], [OK
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/neigh/show | grep br0 | sort], [0], [dnl
>> +2001:cafe::92 aa:bb:cc:00:00:01 br0
>> +])
>> +
>> +ovs-appctl time/warp 5000
>> +
>> +dnl Check the entry has been removed
>> +AT_CHECK([ovs-appctl tnl/neigh/show | grep br0 | sort], [0], [dnl
>> +])
>> +
>> +dnl Restore the ageing time to 900s (default)
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing 900], [0], [OK
>> +])
>> +
>> +dnl Read the current ageing time
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing], [0], [900
>> +])
>> +
>> dnl Check ARP Snoop
>> AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'in_port(1),eth(src=f8:bc:12:44:34:c8,dst=aa:55:aa:55:00:00),eth_type(0x86dd),ipv6(src=2001:cafe::92,dst=2001:cafe::88,label=0,proto=58,tclass=0,hlimit=255,frag=no),icmpv6(type=136,code=0),nd(target=2001:cafe::92,sll=00:00:00:00:00:00,tll=f8:bc:12:44:34:c8)'])
>>
>> @@ -432,6 +462,42 @@ AT_CHECK([ovs-appctl dpif/dump-flows int-br | grep
>> 'in_port(6081)'], [0], [dnl
>>
>> tunnel(tun_id=0x7b,ipv6_src=2001:cafe::92,ipv6_dst=2001:cafe::88,geneve({class=0xffff,type=0x80,len=4,0xa/0xf}{class=0xffff,type=0,len=4}),flags(-df-csum+key)),recirc_id(0),in_port(6081),packet_type(ns=0,id=0),eth_type(0x0800),ipv4(frag=no),
>> packets:0, bytes:0, used:never,
>> actions:userspace(pid=0,controller(reason=1,dont_send=0,continuation=0,recirc_id=3,rule_cookie=0,controller_id=0,max_len=65535))
>> ])
>>
>> +dnl Receive VXLAN with different MAC and verify that the neigh cache gets
>> updated
>> +AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'aa55aa550000f8bc1244cafe86dd60000000003a11402001cafe0000000000000000000000922001cafe000000000000000000000088c85312b5003abc700c00000300007b00ffffffffffff00000000000008004500001c0001000040117cce7f0000017f0000010035003500080172'])
>> +
>> +ovs-appctl time/warp 1000
>> +ovs-appctl time/warp 1000
>> +
>> +dnl Check VXLAN tunnel push
>> +AT_CHECK([ovs-ofctl add-flow int-br action=2])
>> +AT_CHECK([ovs-appctl ofproto/trace ovs-dummy
>> 'in_port(2),eth(src=36:b1:ee:7c:01:01,dst=36:b1:ee:7c:01:02),eth_type(0x0800),ipv4(src=1.1.3.88,dst=1.1.3.112,proto=47,tos=0,ttl=64,frag=no)'],
>> [0], [stdout])
>> +AT_CHECK([tail -1 stdout], [0],
>> + [Datapath actions:
>> clone(tnl_push(tnl_port(4789),header(size=70,type=4,eth(dst=f8:bc:12:44:ca:fe,src=aa:55:aa:55:00:00,dl_type=0x86dd),ipv6(src=2001:cafe::88,dst=2001:cafe::92,label=0,proto=17,tclass=0x0,hlimit=64),udp(src=0,dst=4789,csum=0xffff),vxlan(flags=0x8000000,vni=0x7b)),out_port(100)),1)
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/arp/show | tail -n+3 | sort], [0], [dnl
>> +2001:cafe::92 f8:bc:12:44:ca:fe br0
>> +2001:cafe::93 f8:bc:12:44:34:b7 br0
>> +])
>> +
>> +dnl Restore and check the cache entries
>> +AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'aa55aa550000f8bc124434b686dd60000000003a11402001cafe0000000000000000000000922001cafe000000000000000000000088c85312b5003abc700c00000300007b00ffffffffffff00000000000008004500001c0001000040117cce7f0000017f0000010035003500080172'])
>> +
>> +ovs-appctl time/warp 1000
>> +ovs-appctl time/warp 1000
>> +
>> +dnl Check VXLAN tunnel push
>> +AT_CHECK([ovs-ofctl add-flow int-br action=2])
>> +AT_CHECK([ovs-appctl ofproto/trace ovs-dummy
>> 'in_port(2),eth(src=36:b1:ee:7c:01:01,dst=36:b1:ee:7c:01:02),eth_type(0x0800),ipv4(src=1.1.3.88,dst=1.1.3.112,proto=47,tos=0,ttl=64,frag=no)'],
>> [0], [stdout])
>> +AT_CHECK([tail -1 stdout], [0],
>> + [Datapath actions:
>> clone(tnl_push(tnl_port(4789),header(size=70,type=4,eth(dst=f8:bc:12:44:34:b6,src=aa:55:aa:55:00:00,dl_type=0x86dd),ipv6(src=2001:cafe::88,dst=2001:cafe::92,label=0,proto=17,tclass=0x0,hlimit=64),udp(src=0,dst=4789,csum=0xffff),vxlan(flags=0x8000000,vni=0x7b)),out_port(100)),1)
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/arp/show | tail -n+3 | sort], [0], [dnl
>> +2001:cafe::92 f8:bc:12:44:34:b6 br0
>> +2001:cafe::93 f8:bc:12:44:34:b7 br0
>> +])
>> +
>> ovs-appctl time/warp 10000
>>
>> AT_CHECK([ovs-vsctl del-port int-br t3 \
>> diff --git a/tests/tunnel-push-pop.at b/tests/tunnel-push-pop.at
>> index 12fc1ef91..f23372613 100644
>> --- a/tests/tunnel-push-pop.at
>> +++ b/tests/tunnel-push-pop.at
>> @@ -270,6 +270,36 @@ AT_CHECK([cat p0.pcap.txt | grep 101025d | uniq], [0],
>> [dnl
>>
>> ffffffffffffaa55aa55000008060001080006040001aa55aa550000010102580000000000000101025d
>> ])
>>
>> +dnl Set the ageing time to 5 seconds
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing 5], [0], [OK
>> +])
>> +
>> +dnl Read the current ageing time
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing], [0], [5
>> +])
>> +
>> +dnl Add an entry
>> +AT_CHECK([ovs-appctl tnl/neigh/set br0 1.1.2.92 aa:bb:cc:00:00:01], [0], [OK
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/neigh/show | grep br0 | sort], [0], [dnl
>> +1.1.2.92 aa:bb:cc:00:00:01 br0
>> +])
>> +
>> +ovs-appctl time/warp 5000
>> +
>> +dnl Check the entry has been removed
>> +AT_CHECK([ovs-appctl tnl/neigh/show | grep br0 | sort], [0], [dnl
>> +])
>> +
>> +dnl Restore the ageing time to 900s (default)
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing 900], [0], [OK
>> +])
>> +
>> +dnl Read the current ageing time
>> +AT_CHECK([ovs-appctl tnl/neigh/ageing], [0], [900
>> +])
>> +
>> dnl Check ARP Snoop
>> AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'recirc_id(0),in_port(1),eth(src=f8:bc:12:44:34:c8,dst=ff:ff:ff:ff:ff:ff),eth_type(0x0806),arp(sip=1.1.2.92,tip=1.1.2.88,op=2,sha=f8:bc:12:44:34:c8,tha=00:00:00:00:00:00)'])
>>
>> @@ -522,6 +552,41 @@ AT_CHECK([ovs-appctl dpif/dump-flows int-br | grep
>> 'in_port(6081)'], [0], [dnl
>>
>> tunnel(tun_id=0x7b,src=1.1.2.92,dst=1.1.2.88,geneve({class=0xffff,type=0x80,len=4,0xa/0xf}{class=0xffff,type=0,len=4}),flags(-df-csum+key)),recirc_id(0),in_port(6081),packet_type(ns=0,id=0),eth_type(0x0800),ipv4(frag=no),
>> packets:0, bytes:0, used:never,
>> actions:userspace(pid=0,controller(reason=1,dont_send=0,continuation=0,recirc_id=2,rule_cookie=0,controller_id=0,max_len=65535))
>> ])
>>
>> +dnl Receive VXLAN with different MAC and verify that the neigh cache gets
>> updated
>> +AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'aa55aa550000f8bc1244cafe08004500004e00010000401173e90101025c01010258c85312b5003a8cd40c00000300007b00ffffffffffff00000000000008004500001c0001000040117cce7f0000017f0000010035003500080172'])
>> +
>> +ovs-appctl time/warp 1000
>> +ovs-appctl time/warp 1000
>> +
>> +dnl Check VXLAN tunnel push
>> +AT_CHECK([ovs-ofctl add-flow int-br action=2])
>> +AT_CHECK([ovs-appctl ofproto/trace ovs-dummy
>> 'in_port(2),eth(src=36:b1:ee:7c:01:01,dst=36:b1:ee:7c:01:02),eth_type(0x0800),ipv4(src=1.1.3.88,dst=1.1.3.112,proto=47,tos=0,ttl=64,frag=no)'],
>> [0], [stdout])
>> +AT_CHECK([tail -1 stdout], [0],
>> + [Datapath actions:
>> clone(tnl_push(tnl_port(4789),header(size=50,type=4,eth(dst=f8:bc:12:44:ca:fe,src=aa:55:aa:55:00:00,dl_type=0x0800),ipv4(src=1.1.2.88,dst=1.1.2.92,proto=17,tos=0,ttl=64,frag=0x4000),udp(src=0,dst=4789,csum=0x0),vxlan(flags=0x8000000,vni=0x7b)),out_port(100)),1)
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/neigh/show | tail -n+3 | sort], [0], [dnl
>> +1.1.2.92 f8:bc:12:44:ca:fe br0
>> +1.1.2.93 f8:bc:12:44:34:b7 br0
>> +])
>> +
>> +dnl Restore and check the cache entries
>> +AT_CHECK([ovs-appctl netdev-dummy/receive p0
>> 'aa55aa550000f8bc124434b608004500004e00010000401173e90101025c01010258c85312b5003a8cd40c00000300007b00ffffffffffff00000000000008004500001c0001000040117cce7f0000017f0000010035003500080172'])
>> +
>> +ovs-appctl time/warp 1000
>> +ovs-appctl time/warp 1000
>> +
>> +dnl Check VXLAN tunnel push
>> +AT_CHECK([ovs-appctl ofproto/trace ovs-dummy
>> 'in_port(2),eth(src=36:b1:ee:7c:01:01,dst=36:b1:ee:7c:01:02),eth_type(0x0800),ipv4(src=1.1.3.88,dst=1.1.3.112,proto=47,tos=0,ttl=64,frag=no)'],
>> [0], [stdout])
>> +AT_CHECK([tail -1 stdout], [0],
>> + [Datapath actions:
>> clone(tnl_push(tnl_port(4789),header(size=50,type=4,eth(dst=f8:bc:12:44:34:b6,src=aa:55:aa:55:00:00,dl_type=0x0800),ipv4(src=1.1.2.88,dst=1.1.2.92,proto=17,tos=0,ttl=64,frag=0x4000),udp(src=0,dst=4789,csum=0x0),vxlan(flags=0x8000000,vni=0x7b)),out_port(100)),1)
>> +])
>> +
>> +AT_CHECK([ovs-appctl tnl/neigh/show | tail -n+3 | sort], [0], [dnl
>> +1.1.2.92 f8:bc:12:44:34:b6 br0
>> +1.1.2.93 f8:bc:12:44:34:b7 br0
>> +])
>> +
>> ovs-appctl time/warp 10000
>>
>> AT_CHECK([ovs-vsctl del-port int-br t3 \
>>
>> _______________________________________________
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> --
> fbl
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
