On 10/4/21 16:03, David Marchand wrote: > On Fri, Sep 10, 2021 at 11:08 AM Timothy Redaelli <[email protected]> > wrote: >> >> Currently, there are some patches with the tags wrongly written (with >> space instead of dash ) and this may prevent some automatic system or CI >> to detect them correctly. >> >> This commit adds a check in checkpatch to be sure the tag is written >> correctly with dash and not with space. >> >> The tags supported by the commit are: >> Acked-by, Reported-at, Reported-by, Requested-by, Reviewed-by, Submitted-at >> and Suggested-by. >> >> It's not necessary to add "Signed-off-by" since it's already checked in >> checkpatch. > > Just want to be sure I understand. > checkpatch reports missing sob, but won't flag incorrectly written tags. > > For example: > Author: A > > Signed-off-by: A > Signed off by: B > > I don't think this would be detected. > > > Otherwise, the patch lgtm, the test runs fine. > Thanks.
I applied this patch as is for now. Some enhancements could be added later, if needed. Thanks! Bet regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
