On 10/14/21 12:40 AM, Terry Wilson wrote: > It can be useful to be able to send raw transaction operations > through the Idl's connection. For example, to clean up MAC_Binding > entries for floating IPs without having to monitor the MAC_Binding > table which can be quite large. > > Signed-off-by: Terry Wilson <[email protected]> > ---
Hi Terry, The change looks ok to me and I think it will do what it's supposed to. I have a couple of comments though. Could we add a test to at least exercise this new feature? Would there be a way to do some client side validation for the add_op() arguments? ovsdb-client doesn't do much of that either, except to ensure that the argument to "transact" is really a json object or array string representation. Do we need to document this API somewhere or at least mention it in the NEWS file? Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
