On Mon, Nov 8, 2021 at 10:43 AM Dumitru Ceara <[email protected]> wrote: > > On 11/3/21 5:55 PM, [email protected] wrote: > > From: Numan Siddique <[email protected]> > > > > system-test matrix first runs unit tests and then system tests. > > And if unit tests fail, system tests are not run. > > > > This patch now runs only system tests for system-test matrix. > > A new entry is added in the test matrix - 'gcc compiler with > > unit tests'. > > > > Signed-off-by: Numan Siddique <[email protected]> > > --- > > Hi Numan, > > > > > v1 -> v2 > > ---- > > * Addressed Ilya's comments. > > > > .ci/linux-build.sh | 22 +++++++++++----------- > > .github/workflows/test.yml | 2 ++ > > 2 files changed, 13 insertions(+), 11 deletions(-) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index 76a2ff459f..b0975685d4 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -49,17 +49,6 @@ else > > fi > > > > if [ "$TESTSUITE" ]; then > > - # 'distcheck' will reconfigure with required options. > > - # Now we only need to prepare the Makefile without sparse-wrapped CC. > > - configure_ovn > > - > > - export DISTCHECK_CONFIGURE_FLAGS="$OPTS" > > - if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then > > - # testsuite.log is necessary for debugging. > > - cat */_build/sub/tests/testsuite.log > > - exit 1 > > - fi > > - > > if [ "$TESTSUITE" = "system-test" ]; then > > # Reconfigure build with required OPTS, rebuild and run system > > tests. > > We're not really reconfiguring/rebuilding anymore, this can probably be > updated to: > > # Configure build with required OPTS, build and run system tests. > > Or, even better, the comment can be removed altogether; but I guess this > can be fixed up at apply time, therefore: > > Acked-by: Dumitru Ceara <[email protected]>
Thanks Dumitru. I removed the comment and applied the patch to the main branch. Numan > > Thanks, > Dumitru > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
