On 11/5/21 10:20, Eelco Chaudron wrote: > > > On 4 Nov 2021, at 15:51, Ilya Maximets wrote: > >> Hi, Eelco. Sorry for this taking so long. >> >> The patch looks good to me, just one small nit below. >> >> On 9/6/21 10:53, Eelco Chaudron wrote: >>> This patch adds cache usage statistics to the output: >>> >>> $ ovs-dpctl show >>> system@ovs-system: >>> lookups: hit:24 missed:71 lost:0 >>> flows: 0 >>> masks: hit:334 total:0 hit/pkt:3.52 >>> cache: hit:4 hit rate:4.21% >> >> The space in "hit rate" doesn't look right. All the other things >> are written as a single word followed by a semicolon and a number, >> so maybe this should be a single word too. E.g.: >> >> cache: hit:4 hit-rate:4.21% >> >> What do you think? I can make this change before applying a patch. > > The change looks fine! Please make the change before applying. > > Thanks, > > Eelco > >> Best regards, Ilya Maximets. >> >>> port 0: ovs-system (internal) >>> port 1: genev_sys_6081 (geneve: packet_type=ptap) >>> port 2: br-int (internal) >>> port 3: br-ex (internal) >>> port 4: eth2 >>> port 5: sw1p1 (internal) >>> port 6: sw0p4 (internal) >
Thanks! Applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
