On 11/5/2021 8:26 PM, Eelco Chaudron wrote:
Hi Chris,

Only one thing you forgot to fix from the previous review.

If you make no other changes than the below, you can add my ack.
Done, thanks.

//Eelco

On 21 Oct 2021, at 10:01, Chris Mi wrote:

<SNIP>

+
+static int
+parse_userspace_action(struct tc_flower *flower, struct tc_action *tc_action,
+                       const struct nlattr *userspace_action,
+                       const struct flow_tnl *tnl, uint32_t *group_id,
+                       const ovs_u128 *ufid)
+{
+    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
+    struct dpif_sflow_attr sflow_attr;
+    int err;
+
+    if (*group_id) {
+        VLOG_ERR_RL(&error_rl, "Only a single TC_SAMPLE action per flow is"
+                    " supported");
            VLOG_ERR_RL(&error_rl,
                        "Only a single TC_SAMPLE action per flow is supported");


Done.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to