On 10/25/21 16:36, Michael Santana wrote: > In the case that a client disables jsonrpc probes the client would fail > to detect if the connection to the server has dropped. To workaround > such case TCP keepalive is enabled. > > Signed-off-by: Michael Santana <[email protected]> > ---
Hi, Michael. Thanks for the patch. But I'm not sure why we need this, at least in current form. Standard keepalive configuration on modern systems is set to something around 2 hours most of the time. So, the user might have 2 hours of downtime and not even notice. TCP keepalives might be useful for the case where user knows that application may not reply for a long time, so they have to set the inactivity probe to a higher value. In this case, we could detect connection failure with TCP keepalive using shorter time interval. Having TCP keepalive configured to a very long interval (which is system default), IMHO, doesn't make a lot of sense. I would also argue that inactivity probes should never be disabled, but set to a higher value instead, because TCP keepalive will not be able to detect hanged application, e.g. deadlock. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
