On 11/23/21 18:37, Vladislav Odintsov wrote: > OVN requested-tnl-key VXLAN checks affect tunnel_key in > datapath_binding record only on datapath tunnel key assigning. > If a dp tnl key was already assigned and VXLAN-enabled chassis > is added after that, the value would never be changed. > > The test didn't check the VXLAN-enabled chassis was created and > thus test could fail like this: > > $ ovn.at:3777: waiting until test x`ovn-nbctl lsp-get-up lsp-bad` = xup... > $ ovn.at:3777: wait succeeded immediately > $ ./ovn.at:3777: ovn-sbctl get Datapath_Binding ls-bad tunnel_key > $ --- - 2021-11-23 17:34:51.646403185 +0300 > $ +++ > /builddir/build/BUILD/ovn-21.09.90/tests/testsuite.dir/at-groups/104/stdout > 2021-11-23 17:34:51.644406189 +0300 > $ @@ -1,2 +1,2 @@ > $ -1 > $ +5000 > > This patch fixes such fail by adding await for chassis to be > registered in SB DB. > > Signed-off-by: Vladislav Odintsov <[email protected]> > ---
Looks good to me, thanks! Acked-by: Dumitru Ceara <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
