On 11/30/21 10:43, Eli Britstein wrote:
>
> On 11/30/2021 12:31 AM, Ilya Maximets wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 11/7/21 11:56, Eli Britstein via dev wrote:
>>> Following dpdk commits [1]-[3], it is now possible to compile with
>>> --enable-Werror. Change the default to on, with an option to disable
>>> using --disable-Werror.
>>>
>>> Notes:
>>> 1. To compile against 21.11-rc1, need to apply [4] and [5] patches.
>>> 2. There are still sparse errors, due to dpdk issue. [6] fixes it.
>>>
>>> [1] a3f8d0587188 ("net: avoid cast-align warning in VLAN insert function")
>>> [2] da0333c8790b ("mbuf: avoid cast-align warning in data offset macro")
>>> [3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy functions")
>>> [4] https://patchwork.ozlabs.org/project/openvswitch/list/?series=268844
>>> [5] https://patchwork.ozlabs.org/project/openvswitch/list/?series=261231
>>> [6]
>>> https://patches.dpdk.org/project/dpdk/patch/[email protected]/
>>>
>>> Signed-off-by: Eli Britstein <[email protected]>
>>> Reviewed-by: Gaetan Rivet <[email protected]>
>>> ---
>>> .ci/linux-build.sh | 1 -
>>> .cirrus.yml | 2 +-
>>> acinclude.m4 | 4 ++--
>>> 3 files changed, 3 insertions(+), 4 deletions(-)
>> Hi, Eli. I'm not sure if I understand the reason behind this patch.
>
> In linux x86 at least, we had warnings by dpdk. We discussed it in [7], and
> fixed some in OVS by [8].
>
> The fixes in dpdk were merged (see above [1]-[3]), so I thought to have this
> option by default to prevent future warnings.
Hmm. Maybe it's better to just remove -Wno-cast-align from CI scripts
instead? Current version of a patch will not catch cast-align warnings
in our CI, since they are explicitly disabled.
>
> We did encounter some issue on PPC, still pending to a proper resolution, [9].
>
>
> [7] https://mail.openvswitch.org/pipermail/ovs-dev/2021-July/384773.html
>
> [8] https://mail.openvswitch.org/pipermail/ovs-dev/2021-July/385482.html
>
> [9] https://mail.openvswitch.org/pipermail/ovs-dev/2021-November/389381.html
>
>> But, in any case, I believe that it will break the Windows build, as
>> it currently produces a fair amount of warnings.
>
> I admit I haven't tested windows. I tried to look into it, but could not find
> a free CI tool for that.
>
> I tried to follow
> https://docs.openvswitch.org/en/latest/intro/install/windows/, but could not
> understand what option to choose in http://www.mingw.org/wiki/Getting_Started
>
> Could you please advise?
We're using https://www.appveyor.com/ as a Windows CI. It's free for
public projects. Concurrency is limited to 1 job at a time, but that
should not be a big problem. You should be able to set it up for
yourself. appveyor.yml is included in the OVS repo.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
