On 11/29/21 16:47, Dumitru Ceara wrote: > On 11/22/21 01:09, Ilya Maximets wrote: >> ovsdb_atom_string and json_string are basically the same data structure >> and ovsdb-server frequently needs to convert one to another. We can >> avoid that by using json_string from the beginning for all ovsdb >> strings. So, the conversion turns into simple json_clone(), i.e. >> increment of a reference counter. This change doesn't give any >> significant performance boost, but it improves the code clarity and >> may be useful for future development. >> >> Signed-off-by: Ilya Maximets <[email protected]> >> --- > > I'm assuming this also doesn't cause a visible performance hit because > of extra, non-inlined, calls to json_string(), right?
Actually, I run a few more tests and this patch actually gives about 5-6% performance boost to ovsdb-server in some cases. I'll adjust the commit message a bit before applying. > Then: > > Acked-by: Dumitru Ceara <[email protected]> Thanks! > > Thanks! > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
