On 12/3/21 17:37, Mike Pattrick wrote: > On Fri, Dec 3, 2021 at 9:29 AM Ilya Maximets <[email protected]> wrote: >> >> On 11/12/21 18:49, Mike Pattrick wrote: >>> Currently ingress policing uses the basic classifier to apply traffic >>> control filters if hardware offload is not enabled, else it uses >>> matchall. This change enables fallback onto the matchall classifier for >>> cases when the kernel is not built with basic support and hardware >>> offload is not in use. Basic is still selected first. >> >> Hello, Mike. I'm not sure I understand the reason behind the logic here. >> >> If 'matchall' is better (as you stated in previous versions of a patch), >> why not try it first and fall back to 'basic' if not available? > > I think I was going for maintaining the current behaviour as much as > possible. The matchall classifier is technically more efficient than > basic, but I wasn't able to find a noticeable difference in my > testing. > > If you prefer, I can flip that logic?
'matchall' seems to be more accurate. At least from the configuration point of view, so it's probably better to use it if possible. > > Cheers, > Michael > >> Best regards, Ilya Maximets. >> > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
