On 12/3/21 16:32, Emma Finn wrote:
> From: Kumar Amber <[email protected]>
> 
> This commit adds a new command to allow the user to enable
> autovalidatior by default at build time thus allowing for
> runnig unit test by default.
> 
>  $ ./configure --enable-actions-default-autovalidator
> 
> Signed-off-by: Kumar Amber <[email protected]>
> 
> ---
> v3:
> - Removed Emma's sign-off for this commit
> ---
> ---
>  acinclude.m4      | 17 +++++++++++++++++
>  configure.ac      |  1 +
>  lib/odp-execute.c |  4 ++++
>  3 files changed, 22 insertions(+)
> 

Hi, Emma.  Not a review.  I'm just replying to ask: please, try
to not name the patches equally to ones already accepted.

There is already a patch named "dpif-netdev: Add configure to enable
autovalidator at build time." in the git history and that confuses
some patchwork tooling a lot.

I'll mark this one patch as 'changes-requested' for now to avoid
issues with patchwork tools.

BTW, having the equally named patches also means that the patch names
are not informative enough.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to