On 12/6/21 18:11, David Marchand wrote: > On Tue, Nov 23, 2021 at 3:01 PM Kevin Traynor <[email protected]> wrote: >> >> It seems that on slow system with high concurrency and cpu contention >> time/warp is not accurate enough for the ALB unit tests with the minimum >> time/warp that was used to hit an amount of events. This results in some >> intermittent test failures. >> >> As those tests are just waiting for a certain amount of events to occur >> and there is no functional change during that time let's do the time/warp >> again with higher values. >> >> With this no failures are seen in several hundred runs. >> >> Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.") >> Reported-by: Ilya Maximets <[email protected]> > > Fwiw, I managed to reproduce with below commands (test failed in 7 > runs out of 10 on my laptop before patch). > > In separate terminals: > $ taskset -c 3 sh -c 'while true; do true; done' > $ taskset -c 3 make -C master check TESTSUITEFLAGS="-d 1026" > >> Signed-off-by: Kevin Traynor <[email protected]> > > Reviewed-by: David Marchand <[email protected]> > > I let the test run ~50 times, no issue with patch.
Thanks, Kevin and David! Applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
