Bleep bloop. Greetings Josh Soref, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#612 FILE: NEWS:315:
* Datapath classifier code refactored to enable function pointers to select
WARNING: Line is 80 characters long (recommended limit is 79)
#1863 FILE: lib/bfd.c:77:
* unidirectional failures). BFD has a demand mode in which it can stay quiet
WARNING: Line is 95 characters long (recommended limit is 79)
#2130 FILE: lib/dpctl.man:134:
\fBpartially-offloaded\fR - displays flows where only part of their
processing is done in HW
WARNING: Comment with 'xxx' marker
#2360 FILE: lib/dpif-netlink.c:1048:
/* XXX : Map appropriate Windows handle */
WARNING: Line is 80 characters long (recommended limit is 79)
#2812 FILE: lib/netdev.h:93:
* header with the proper Ethertype; on transmission, the Ethernet header is
WARNING: Line has non-spaces leading whitespace
WARNING: Line lacks whitespace around operator
#3210 FILE: lib/sflow_poller.c:79:
In a large network, even this might not be ideal if
time-synchronization
WARNING: Line is 82 characters long (recommended limit is 79)
WARNING: Line has non-spaces leading whitespace
WARNING: Line lacks whitespace around operator
#3218 FILE: lib/sflow_poller.c:86:
The packet-sample events are not synchronized to any clock, so that
results in
WARNING: Line has non-spaces leading whitespace
#3227 FILE: lib/sflow_poller.c:95:
Andy Kitchingman for spotting this omission. */
WARNING: Line is 98 characters long (recommended limit is 79)
ERROR: C99 style comment
#3240 FILE: lib/sflow_receiver.c:208:
// answer in bytes, so remember to multiply by 4 after rounding up to
nearest 4-byte boundary
ERROR: C99 style comment
#3249 FILE: lib/sflow_receiver.c:502:
// important to avoid overrunning the packet buffer.
ERROR: C99 style comment
#3258 FILE: lib/sflow_receiver.c:685:
// important to avoid overrunning the packet buffer.
WARNING: Line is 89 characters long (recommended limit is 79)
#3592 FILE: ofproto/ofproto-dpif.c:6276:
ds_put_cstr(ds, "Can not enable features not supported by the
datapath");
WARNING: Line is 94 characters long (recommended limit is 79)
#5278 FILE: windows/ovs-windows-installer/ovs-windows-installer.wixproj:16:
<TestOutOfProcess Condition=" '$(PROCESSOR_ARCHITECTURE)'!='x86'
">true</TestOutOfProcess>
WARNING: Line is 94 characters long (recommended limit is 79)
#5287 FILE: windows/ovs-windows-installer/ovs-windows-installer.wixproj:25:
<TestOutOfProcess Condition=" '$(PROCESSOR_ARCHITECTURE)'!='x86'
">true</TestOutOfProcess>
WARNING: Line is 372 characters long (recommended limit is 79)
#5296 FILE: windows/ovs-windows-installer/ovs-windows-installer.wixproj:72:
<HeatDirectory RunAsSeparateProcess="$(TestOutOfProcess)"
DirectoryRefId="BINARIESDIR" OutputFile="Binaries.wxs" Directory="Binaries"
ComponentGroupName="BinariesComponentGroup" ToolPath="$(WixToolPath)"
PreprocessorVariable="var.BinariesPath" GenerateGuidsNow="true"
SuppressCom="true" SuppressRegistry="true" KeepEmptyDirectories="true"
SuppressRootDirectory="true">
WARNING: Line is 367 characters long (recommended limit is 79)
#5299 FILE: windows/ovs-windows-installer/ovs-windows-installer.wixproj:74:
<HeatDirectory RunAsSeparateProcess="$(TestOutOfProcess)"
DirectoryRefId="SYMBOLSDIR" OutputFile="Symbols.wxs" Directory="Symbols"
ComponentGroupName="SymbolsComponentGroup" ToolPath="$(WixToolPath)"
PreprocessorVariable="var.SymbolsPath" GenerateGuidsNow="true"
SuppressCom="true" SuppressRegistry="true" KeepEmptyDirectories="true"
SuppressRootDirectory="true">
Lines checked: 5331, Warnings: 17, Errors: 3
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
