On 12/13/21 18:28, Mike Pattrick wrote:
> This commit adds a basic packet metadata macro to the already existing
> macros in ovs_gdb.py, ovs_dump_packets will print out information about
> one or more packets. It feeds packets into tcpdump, and the user can
> pass in tcpdump options to modify how packets are parsed or even write
> out packets to a pcap file.
> 
> Example usage:
> (gdb) break fast_path_processing
> (gdb) commands
>  ovs_dump_packets packets_
>  continue
>  end
> (gdb) continue
> 
> Thread 1 "ovs-vswitchd" hit Breakpoint 2, fast_path_processing ...
> 12:01:05.962485 ARP, Ethernet (len 6), IPv4 (len 4), Request who-has
>     10.1.1.1 tell 10.1.1.2, length 28
> 
> Thread 1 "ovs-vswitchd" hit Breakpoint 1, fast_path_processing ...
> 12:01:05.981214 ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.1.1.1
>     is-at a6:0f:c3:f0:5f:bd (oui Unknown), length 28
> 
> Signed-off-by: Mike Pattrick <[email protected]>
> ---
>  utilities/automake.mk    |   1 +
>  utilities/gdb/ovs_gdb.py | 203 ++++++++++++++++++++++++++++++++-------
>  2 files changed, 167 insertions(+), 37 deletions(-)
> 
> diff --git a/utilities/automake.mk b/utilities/automake.mk
> index e2e22c39a..7808c0ead 100644
> --- a/utilities/automake.mk
> +++ b/utilities/automake.mk
> @@ -126,6 +126,7 @@ endif
>  
>  FLAKE8_PYFILES += utilities/ovs-pcap.in \
>       utilities/checkpatch.py utilities/ovs-dev.py \
> +     utilities/gdb/ovs_gdb.py \


Looks like flake8/python version used by GHA is not happy with some
of the class declarations:

utilities/gdb/ovs_gdb.py:92:1: H238: old style class declaration, use new style 
(inherit from `object`)
utilities/gdb/ovs_gdb.py:306:1: H238: old style class declaration, use new 
style (inherit from `object`)
utilities/gdb/ovs_gdb.py:397:1: H238: old style class declaration, use new 
style (inherit from `object`)
utilities/gdb/ovs_gdb.py:427:1: H238: old style class declaration, use new 
style (inherit from `object`)

https://github.com/ovsrobot/ovs/runs/4509830943?check_suite_focus=true#step:12:1901

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to