On Tue, Dec 14, 2021 at 4:55 PM Ilya Maximets <[email protected]> wrote:
> >> +you see a message like the following one in the OVS logs, it means that
> >> there
> >> +is no specialized implementation available for the current networking
> >> traffic.
> >> +In this case, OVS will continue to process the traffic normally using a
> >> more
> >> +generic lookup table.::
> >
> > I don't really get the intention for this part.
> >
> > This is rendered as "generic lookup table.:" and I don't get the
> > relation with the sentence below.
> > So I would simply end this sentence above with a .
>
>
> I think, the sentences should be swapped. Something like this:
>
> ...
> If you see a message like the following one in the OVS logs, it means that
> there
> is no specialized implementation available for the current network traffic::
>
> Using non-specialized AVX512 lookup for subtable (X,Y) and possibly others.
>
> In this case, OVS will continue to process the traffic normally using a more
> generic lookup table.
> ...
>
> And the (Note ...) part below can actually be removed.
>
> What do you think?
Ah ok.
This is better as you propose.
>
> >
> >
> >> -"Using non-specialized AVX512 lookup for subtable (4,1) and possibly
> >> others."
> >> + Using non-specialized AVX512 lookup for subtable (4,1) and possibly
> >> others.
> >
> > And make this a sub paragraph title instead.
> >
> >
> >>
> >> (Note that the numbers 4 and 1 will likely be different in your logs)
> >>
> >> -Additional specialized lookups can be added to OVS if the user
> >> -provides that log message along with the command output as show
> >> -below to the OVS mailing list. Note that the numbers in the log
> >> -message ("subtable (X,Y)") need to match with the numbers in
> >> -the provided command output ("dp-extra-info:miniflow_bits(X,Y)").
> >> +Additional specialized lookups can be added to OVS if the user provides
> >> that
> >> +log message along with the command output as show below to the OVS mailing
> >> +list. Note that the numbers in the log message (``subtable (X,Y)``) need
> >> to
> >> +match with the numbers in the provided command output
> >> +(``dp-extra-info:miniflow_bits(X,Y)``).
> >>
> >> -"ovs-appctl dpctl/dump-flows -m", which results in output like this:
> >> +``ovs-appctl dpctl/dump-flows -m``, which results in output like this::
> >>
> >> ufid:82770b5d-ca38-44ff-8283-74ba36bd1ca5,
> >> skb_priority(0/0),skb_mark(0/0)
> >> ,ct_state(0/0),ct_zone(0/0),ct_mark(0/0),ct_label(0/0),recirc_id(0),
[snip]
> >> diff --git a/Documentation/topics/testing.rst
> >> b/Documentation/topics/testing.rst
> >> index ea11700e3..85797df07 100644
> >> --- a/Documentation/topics/testing.rst
> >> +++ b/Documentation/topics/testing.rst
> >> @@ -356,7 +356,64 @@ The phy test will skip if no compatible physical
> >> device is available.
> >> .. _Configure hugepages:
> >> https://doc.dpdk.org/guides-21.11/linux_gsg/sys_reqs.html
> >>
> >> All the features documented under `Unit Tests`_ are available for the DPDK
> >> -datapath testsuite.
> >> +testsuite.
> >> +
> >> +Userspace datapath: CPU ISA Testing and Validation
> >> +''''''''''''''''''''''''''''''''''''''''''''''''''
> >
> > It could be worth rewording (or in a followup patch?): this block is
> > not about testing CPU ISA, but about testing optimisations of some
> > parts of OVS.
>
>
> Userspace datapath: Testing and Validation of CPU-specific Optimizations
>
> ?
+1
Thanks.
--
David Marchand
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
