On 12/13/21 13:52, David Marchand wrote: > On Wed, Nov 10, 2021 at 5:54 PM David Marchand > <[email protected]> wrote: >> >> Previously in OVS, a PMD thread running on cpu X used lcore X. >> This assumption limited OVS to run PMD threads on physical cpu < >> RTE_MAX_LCORE. >> >> DPDK 20.08 introduced a new API that associates a non-EAL thread to a free >> lcore. This new API does not change the thread characteristics (like CPU >> affinity) and let OVS run its PMD threads on any cpu regardless of >> RTE_MAX_LCORE. >> >> The DPDK multiprocess feature is not compatible with this new API and is >> disabled. >> >> DPDK still limits the number of lcores to RTE_MAX_LCORE (128 on x86_64) >> which should be enough for OVS pmd threads (hopefully). >> >> DPDK lcore/OVS pmd threads mapping are logged at threads when trying to >> attach a OVS PMD thread, and when detaching. >> A new command is added to help get DPDK point of view of the DPDK lcores >> at any time: >> >> $ ovs-appctl dpdk/lcore-list >> lcore 0, socket 0, role RTE, cpuset 0 >> lcore 1, socket 0, role NON_EAL, cpuset 1 >> lcore 2, socket 0, role NON_EAL, cpuset 15 >> >> Signed-off-by: David Marchand <[email protected]> >> Acked-by: Kevin Traynor <[email protected]> > > Any chance to get this merged this week?
Hi, David. It is important to be able to use higher CPUs for OVS since the numbering may largely differ between systems to the point where we might not be able to run any thread on a certain NUMA node. Multiprocess mode we're not supporting anyway as we can't guarantee the correctness, and also --in-memory is a default now. The patch itself looks fine to me. I didn't test it yet, but I do not foresee any problems with that. Ian, you were validating v7, do you have any further comments for this change? And since we moved to 21.11, I think, this patch can go directly to the master branch now skipping the dpdk-latest. There should be no need to re-post for that. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
