On 29 Dec 2021, at 19:51, Paolo Valerio wrote:

> Eelco Chaudron <[email protected]> writes:
>
>> This patch adds a series of NetLink flow operation USDT probes.
>> These probes are in turn used in the upcall_cost Python script,
>> which in addition of some kernel tracepoints, give an insight into
>> the time spent on processing upcall.
>>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>> v2:
>>  - Fixed path naming
>>  - Fixed some typos
>>  - Updated script header
>>
>
> TIME seems a bit misaligned, althought it's not that important (it's
> more a reference rather than a pretty print):

Guess it depends on how long your system has been up and running ;)

> EVENT                    COMM                  PID  CPU  TIME                
> EVENT DATA[dpif_name/dp_port/pkt_len/pkt_frag_len]
> [openvswitch__dp_upcall] iperf             1959468 [010]   119564.082192551: 
> ovs-system           2  118    0
> [openvswitch__dp_upcall] iperf             1959499 [004]   119564.082192633: 
> ovs-system           2  118    0
> ...
>

Thanks for reviewing Paolo!

> Other than that,
> Acked-by: Paolo Valerio <[email protected]>
>
>>  Documentation/topics/usdt-probes.rst  |   86 ++
>>  lib/dpif-netlink.c                    |   16
>>  utilities/automake.mk                 |    4
>>  utilities/usdt_scripts/upcall_cost.py | 1787 
>> +++++++++++++++++++++++++++++++++
>>  4 files changed, 1892 insertions(+), 1 deletion(-)
>>  create mode 100755 utilities/usdt_scripts/upcall_cost.py

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to