> -----Original Message----- > From: Finn, Emma <[email protected]> > Sent: Wednesday, January 5, 2022 4:54 PM > To: [email protected]; Van Haaren, Harry <[email protected]>; > Amber, Kumar <[email protected]> > Cc: Finn, Emma <[email protected]> > Subject: [PATCH v4 3/9] odp-execute: Add auto validation function for actions. > > This commit introduced the auto-validation function which > allows users to compare the batch of packets obtained from > different action implementations against the linear > action implementation. > > The autovalidator function can be triggered at runtime using the > following command: > > $ ovs-appctl dpif-netdev/action-impl-set autovalidator > > Signed-off-by: Emma Finn <[email protected]>
One small comment below, with that Acked-by: Harry van Haaren <[email protected]> > static struct odp_execute_action_impl action_impls[] = { > [ACTION_IMPL_SCALAR] = { > @@ -38,6 +39,13 @@ static struct odp_execute_action_impl action_impls[] = { > .probe = NULL, > .init_func = odp_action_scalar_init, > }, > + > + [ACTION_IMPL_AUTOVALIDATOR] = { > + .available = 1, > + .name = "autovalidator", > + .probe = NULL, > + .init_func = action_autoval_init, > + }, > }; Other components always list Autovalidator as first in the list (0th item): ./utilities/ovs-appctl dpif-netdev/subtable-lookup-prio-get 0 : autovalidator 1 : generic 0 : avx512_gather Keeping that same list order is nice - autovalidator as top item, then generic impls, then ISA impls. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
