On Wed, Jan 12, 2022 at 8:44 AM Lorenzo Bianconi <[email protected]> wrote: > > > On Tue, Jan 11, 2022 at 2:19 PM Lorenzo Bianconi > > <[email protected]> wrote: > > > > > > Since commit 4597317f1 ("Introduce incremental processing for northd"), > > > we rely on (partial) IP for ovn-northd. We need to track SB port_binding > > > option column in order to notify the CMS whenever the controller > > > receives the IPv6 prefix from the server. > > > > > > Fixes: 4597317f1 ("Introduce incremental processing for northd") > > > Signed-off-by: Lorenzo Bianconi <[email protected]> > > > > Hi Lorenzo, > > > > The fix makes sense to me. Do you think it's straightforward to add a > > test case for this ? > > If so, I'd suggest adding one. > > Hi Numan, > > we already have one full-test in system-ovn.at. I posted a patch to replace > dibbler (no longer maintained) with dhcpd so we can enable it by default in > github repo. >
I forgot that Ipv6 PD can't be tested with unit tests. Thanks Numan > Regards, > Lorenzo > > > > > Thanks > > Numan > > > > > --- > > > northd/ovn-northd.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > > > index 2b58bfcec..793135ede 100644 > > > --- a/northd/ovn-northd.c > > > +++ b/northd/ovn-northd.c > > > @@ -786,7 +786,8 @@ main(int argc, char *argv[]) > > > &sbrec_port_binding_col_parent_port); > > > add_column_noalert(ovnsb_idl_loop.idl, &sbrec_port_binding_col_tag); > > > add_column_noalert(ovnsb_idl_loop.idl, &sbrec_port_binding_col_type); > > > - add_column_noalert(ovnsb_idl_loop.idl, > > > &sbrec_port_binding_col_options); > > > + ovsdb_idl_track_add_column(ovnsb_idl_loop.idl, > > > + &sbrec_port_binding_col_options); > > > add_column_noalert(ovnsb_idl_loop.idl, &sbrec_port_binding_col_mac); > > > add_column_noalert(ovnsb_idl_loop.idl, > > > &sbrec_port_binding_col_nat_addresses); > > > -- > > > 2.34.1 > > > > > > _______________________________________________ > > > dev mailing list > > > [email protected] > > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
