On Wed, Jan 12, 2022 at 4:48 PM Phelan, Michael
<[email protected]> wrote:
>
> Hi,
>
> During internal testing of the AVX-512 CI, a bug was picked up on the OVS
> master branch which resulted in the MFEX unit tests consistently failing. I
> believe the bug was introduced by commit
> d446dcb7e03fc7bd4e3050c83c22233b0a46d364 “system-dpdk: Refactor common logs
> matching”. It looks like this commit changed the logs which in turn meant
> that the expected output became outdated causing the unit tests to fail. The
> unit tests are still failing with the most recent updates to master so this
> bug does not seem to have been fixed with any commits that have come after
> the one specified.
Thanks for reporting.
I did not recheck my series after the dpdk upgrade to 21.11 (with only
the first patch applied and the whole series does not have the issue
since it does not rely on net/pcap anymore).
Could you try the following diff:
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index 1dd7aae1b..922f27032 100644
--- a/tests/system-dpdk.at
+++ b/tests/system-dpdk.at
@@ -243,7 +243,10 @@ OVS_WAIT_UNTIL([test `ovs-vsctl get interface p1
statistics | grep -oP 'rx_packe
dnl Clean up
AT_CHECK([ovs-vsctl del-port br0 p1], [], [stdout], [stderr])
-OVS_VSWITCHD_STOP("[SYSTEM_DPDK_ALLOWED_LOGS]")
+OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
+\@Interface p1 does not support MTU configuration, max packet size
supported is 1500.@d
+\@Rx checksum offload is not supported on port 0@d
+])")
AT_CLEANUP
dnl --------------------------------------------------------------------------
@@ -271,7 +274,10 @@ OVS_WAIT_UNTIL([test `ovs-vsctl get interface p1
statistics | grep -oP 'rx_packe
dnl Clean up
AT_CHECK([ovs-vsctl del-port br0 p1], [], [stdout], [stderr])
-OVS_VSWITCHD_STOP("[SYSTEM_DPDK_ALLOWED_LOGS]")
+OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
+\@Interface p1 does not support MTU configuration, max packet size
supported is 1500.@d
+\@Rx checksum offload is not supported on port 0@d
+])")
AT_CLEANUP
dnl --------------------------------------------------------------------------
@@ -389,6 +395,8 @@ OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
\@Error: no miniflow extract name provided. Output of
miniflow-parser-get shows implementation list.@d
\@Error: unknown miniflow extract implementation superstudy.@d
\@Error: invalid study_pkt_cnt value: -pmd.@d
+\@Interface p1 does not support MTU configuration, max packet size
supported is 1500.@d
+\@Rx checksum offload is not supported on port 0@d
])")
AT_CLEANUP dnl
dnl --------------------------------------------------------------------------
--
David Marchand
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
