Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#397 FILE: lib/ovs-numa.h:71:
HMAP_FOR_EACH(ITER, hmap_node, &(DUMP)->cores)
ERROR: Improper whitespace around control block
#401 FILE: lib/ovs-numa.h:74:
HMAP_FOR_EACH(ITER, hmap_node, &(DUMP)->numas)
ERROR: Improper whitespace around control block
#438 FILE: lib/ovsdb-idl.c:1350:
LIST_FOR_EACH_SAFE(row, track_node, &table->track_list) {
ERROR: Improper whitespace around control block
#506 FILE: lib/ovsdb-idl.c:2334:
LIST_FOR_EACH_SAFE(row, track_node, &table->track_list) {
ERROR: Improper whitespace around control block
#543 FILE: lib/tnl-ports.c:269:
LIST_FOR_EACH_SAFE(p, node, &port_list) {
ERROR: Improper whitespace around control block
#557 FILE: lib/tnl-ports.c:451:
LIST_FOR_EACH_SAFE(ip_dev, node, &addr_list) {
ERROR: Improper whitespace around control block
#570 FILE: lib/tnl-ports.c:472:
LIST_FOR_EACH_SAFE(ip_dev, node, &addr_list) {
ERROR: Improper whitespace around control block
#583 FILE: lib/tnl-ports.c:486:
LIST_FOR_EACH_SAFE(ip_dev, node, &addr_list) {
Lines checked: 1316, Warnings: 0, Errors: 8
build:
mv -f $depbase.Tpo $depbase.Plo
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Werror -g -O2 -MT lib/id-fpool.lo -MD -MP -MF lib/.deps/id-fpool.Tpo
-c lib/id-fpool.c -o lib/id-fpool.o
lib/id-fpool.c: In function 'id_fpool_destroy':
lib/id-fpool.c:173:60: error: macro "LIST_FOR_EACH_SAFE" passed 4 arguments,
but takes just 3
LIST_FOR_EACH_SAFE (slab, next, node, &pool->free_slabs) {
^
lib/id-fpool.c:173:5: error: 'LIST_FOR_EACH_SAFE' undeclared (first use in this
function)
LIST_FOR_EACH_SAFE (slab, next, node, &pool->free_slabs) {
^
lib/id-fpool.c:173:5: note: each undeclared identifier is reported only once
for each function it appears in
lib/id-fpool.c:173:62: error: expected ';' before '{' token
LIST_FOR_EACH_SAFE (slab, next, node, &pool->free_slabs) {
^
lib/id-fpool.c:169:21: error: unused variable 'next' [-Werror=unused-variable]
struct id_slab *next;
^
lib/id-fpool.c:168:21: error: unused variable 'slab' [-Werror=unused-variable]
struct id_slab *slab;
^
cc1: all warnings being treated as errors
make[2]: *** [lib/id-fpool.lo] Error 1
make[2]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
