On 2022-01-27 3:32 PM, Eelco Chaudron wrote:
This series fixes a bunch of TC offload-related issues found when running the kernel data path self-test (make check-kernel) forcing TC to be enabled. To do this manually I applied the following diff: https://github.com/chaudron/ovs/commit/d7ff1060f371e2cbd4b2e8dee222a9eed55073c8 These changes are OVS-related fixes, however, I have still two problems that look kernel to investigate. I'm also planning to find a nice way to include the system-traffic.at into "make check-offloads". However, this might take some time, and I do not want to delay getting the actual fixes in. The following branch has some raw changes to system-traffic.at to make most of the tests work with TC enabled hardcoded: https://github.com/chaudron/ovs/tree/dev/tc_verify Eelco Chaudron (10): netdev-offload-tc: Add debug logs on tc rule verify failures netdev-offload-tc: Set the correct VLAN_VID and VLAN_PCP masks odp_util: Fix parse_key_and_mask_to_match() vlan parsing netdev-offload-tc: Check for valid netdev ifindex in flow_put netdev-offload-tc: Always include conntrack information to tc netdev-offload-tc: Fix use of ICMP values instead of masks defines. netdev-offload-tc: Fix IP and port ranges in flower returns. netdev-offload-tc: Check for none offloadable ct_state flag combination netdev-offload-tc: stats should be captured on first action in the list revalidator: Fix datapath statistics update. lib/netdev-offload-tc.c | 27 +++- lib/odp-util.c | 41 ++++-- lib/tc.c | 243 ++++++++++++++++++++++++++-------- ofproto/ofproto-dpif-upcall.c | 8 +- 4 files changed, 243 insertions(+), 76 deletions(-) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Eelco, The series looks good. I don't have any comments beside the sparse error I see you commented yourself and the ovs build robot failed. I'm going to also run some quick internal tests we have with real setup to check nothing basic we do breaks. Thanks, Roi _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
