Adrian Moreno <amore...@redhat.com> writes:

> diff --git a/python/ovs/flows/decoders.py b/python/ovs/flows/decoders.py
> new file mode 100644
> index 000000000..73d5c0c60
> --- /dev/null
> +++ b/python/ovs/flows/decoders.py
> @@ -0,0 +1,18 @@
> +""" Defines helpful decoders that can be used to decode information from the

Leading whitespace?

[...]

> --- /dev/null
> +++ b/python/ovs/flows/kv.py
> @@ -0,0 +1,320 @@
> +""" Common helper classes for flow Key-Value parsing.

Id.

> +class KeyMetadata(object):
> +    """Class for keeping key metadata.
> +

[...]

> +        delim (string): Optional, the string use as delimiter between the key
> +            and the value.
> +        end_delim (string): Optional, the string use as end delimiter between
> +            the key and the value.

Either s/string use/string used/ or s/string use/string to use/ ?

> +class KVDecoders(object):

[...]

> +    @staticmethod
> +    def _default_free_decoder(key):
> +        """Default decoder for free kewords."""

keywords

[...]

> +parenthesys_pattern = re.compile(r"(\(|\))")

Not sure if this spelling is intentional or?

-- 
James
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to