On 1/25/22 11:18, Wan Junjie wrote: > When upcall/show is used to collect upcall statistics from a grafana > collector or some agent, upcall/show can be called even during ovs > restart. Occassionally ovs will crash when the revalidator thread > is not really inited. Backtrace: > > warning: Unexpected size of section '.reg-xstate/3731535' in core file. > 2885 ofproto/ofproto-dpif-upcall.c: No such file or directory. > [Current thread is 1 (Thread 0x7f60b32d8440 (LWP 3731535))] > (gdb) bt > - 0 upcall_unixctl_show (conn=0x55fb517f0770, argc=<optimized out>, > argv=<optimized out>, aux=<optimized out>) at > ofproto/ofproto-dpif-upcall.c:2885 > - 1 0x000055fb4e5468fa in process_command (request=<optimized out>, > conn=0x55fb517f0770) at lib/unixctl.c:308 > - 2 run_connection (conn=0x55fb517f0770) at lib/unixctl.c:342 > - 3 unixctl_server_run (server=0x55fb4fef9300) at lib/unixctl.c:393 > - 4 0x000055fb4df73c0f in main (argc=<optimized out>, argv=<optimized out>) > at v$witchd/ovs-v$witchd.c:140 > > Signed-off-by: Wan Junjie <[email protected]> > ---
Good catch, Thanks! This fix especially important for 2.16+ where the global n_revalidators can be very different from the actual number of created threads. Applied and backported down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
