Dumitru Ceara <[email protected]> writes:

> Remove the forced cache-line size alignment markers from
> struct dp_netdev_pmd_thread and struct dp_netdev as discussed
> at [0].  They don't seem to add any benefit and cause 64 byte
> alignment requirements.
>
> UB Sanitizer report:
>   lib/dpif-netdev.c:6758:13: runtime error: member access within misaligned 
> address 0x7f7f24d25010 for type 'struct dp_netdev_pmd_thread', which requires 
> 64 byte alignment
>   0x7f7f24d25010: note: pointer points here
>    00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 
> 00 00 00 00  00 00 00 00
>                 ^
>      #0 0x5fbfde in dp_netdev_configure_pmd lib/dpif-netdev.c:6758
>      #1 0x5fbde9 in dp_netdev_set_nonpmd lib/dpif-netdev.c:6715
>      #2 0x5d6fdd in create_dp_netdev lib/dpif-netdev.c:1769
>      #3 0x5d72d0 in dpif_netdev_open lib/dpif-netdev.c:1807
>      #4 0x61c83f in do_open lib/dpif.c:347
>      [...]
>   lib/dpif-netdev.c:1724:6: runtime error: member access within misaligned 
> address 0x000002005eb0 for type 'struct dp_netdev', which requires 64 byte 
> alignment
>   0x000002005eb0: note: pointer points here
>    00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 
> 00 00 00 00  00 00 00 00
>                 ^
>       #0 0x5d6660 in create_dp_netdev lib/dpif-netdev.c:1724
>       #1 0x5d72d0 in dpif_netdev_open lib/dpif-netdev.c:1807
>       #2 0x61c846 in do_open lib/dpif.c:347
>       #3 0x61ca9c in dpif_create lib/dpif.c:402
>       #4 0x61cac9 in dpif_create_and_open lib/dpif.c:415
>       #5 0x48f235 in open_dpif_backer ofproto/ofproto-dpif.c:776
>       [...]
>
> [0] https://mail.openvswitch.org/pipermail/ovs-dev/2021-December/390256.html
>
> Suggested-by: Ilya Maximets <[email protected]>
> Signed-off-by: Dumitru Ceara <[email protected]>
> ---

Acked-by: Paolo Valerio <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to