On 2/1/22 11:15, Dumitru Ceara wrote:
> When reconnecting, if there are condition changes already sent to the
> server but not yet acked, reset the db's 'last-id', esentially clearing
> the local cache after reconnect.
>
> This is needed because the client cannot easily differentiate between
> the following cases:
> a. either the server already processed the requested monitor
> condition change but the FSM was restarted before the
> client was notified. In this case the client should
> clear its local cache because it's out of sync with the
> monitor view on the server side.
> b. OR the server hasn't processed the requested monitor
> condition change yet.
>
> Conditions changing at the same time with a reconnection happening are
> rare so the performance impact of this patch should be minimal.
>
> Also, the tests are updated to cover the fact that we cannot control
> which of the two scenarios ("a" and "b" above) are hit during the test.
>
> This also backports a small behavior change introduced in newer releases
> by 1c337c43ac1c ("ovsdb-idl: Break into two layers."): when restarting
> the FSM, if a new condition has been set and there is also an in-flight
> condition change, then the one that's in-flight can be ignored.
>
> Reported-by: Maxime Coquelin <[email protected]>
> Acked-by: Han Zhou <[email protected]>
> (cherry picked from commit c1691cceac322d8a49a6aeb52a608362385ae037)
> Signed-off-by: Dumitru Ceara <[email protected]>
> ---
> Note: This patch currently applies cleanly to branch-2.13 too (unit
> tests pass too).
> Changes from master patch:
> - removed Ilya's sign-off
> - added some bits from 1c337c43ac1c ("ovsdb-idl: Break into two
> layers.") to simplify the backport (and potential future changes).
> ---
>
Thanks! Applied to 2.14 and 2.13.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
