On 1/25/22 10:09, Eelco Chaudron wrote: > > > On 24 Jan 2022, at 12:50, Adrian Moreno wrote: > >> We are currently requiring in_port to be a valid port number for ipfix >> sampling even if the sampling is done on the output port (egress). >> >> This restriction is not really needed and can affect pipelines that >> intentionally set the in_port to OFPP_NONE during flow processing. For >> instance, OVN does this, see: >> >> cfa547821 Fix ovn-controller generated packets from getting dropped for >> reject ACL action. >> >> This patch skips ipfix sampling only if both (ingress and egress) ports >> are invalid. >> >> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2016346 >> Signed-off-by: Adrian Moreno <[email protected]> >> --- > > Thanks for adding the test. Reviewed and tested and it looks good! > > Acked-by: Eelco Chaudron <[email protected]>
Thanks, Adrian and Eelco! Applied and backported down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
