On 2/11/22 12:36, Adrian Moreno wrote:
>
>
> On 2/9/22 16:46, Dumitru Ceara wrote:
>> On 2/9/22 16:23, Dumitru Ceara wrote:
>>> However, that's not the only issue with sparse. It seems on specific
>>> distributions (e.g., on my Fedora 34 test machine) sparse fails to use
>>> the right headers. I made it work with this change, although I'm not
>>> sure this is the best way of doing things:
>>>
>>> diff --git a/acinclude.m4 b/acinclude.m4
>>> index 0c360fd1ef73..f704bf36cdfe 100644
>>> --- a/acinclude.m4
>>> +++ b/acinclude.m4
>>> @@ -1424,7 +1424,7 @@ AC_DEFUN([OVS_ENABLE_SPARSE],
>>> : ${SPARSE=sparse}
>>> AC_SUBST([SPARSE])
>>> AC_CONFIG_COMMANDS_PRE(
>>> - [CC='$(if $(C:0=),env REAL_CC="'"$CC"'" CHECK="$(SPARSE)
>>> $(SPARSE_WERROR) -I $(top_srcdir)/include/sparse $(SPARSEFLAGS)
>>> $(SPARSE_EXTRA_INCLUDES) " cgcc $(CGCCFLAGS),'"$CC"')'])
>>> + [CC='$(if $(C:0=),env REAL_CC="'"$CC"'" CHECK="$(SPARSE)
>>> $(SPARSE_WERROR) -I $(top_srcdir)/include/sparse -I
>>> $(top_srcdir)/include $(SPARSEFLAGS) $(SPARSE_EXTRA_INCLUDES) " cgcc
>>> $(CGCCFLAGS),'"$CC"')'])
>>> AC_ARG_ENABLE(
>>> [sparse],
>>> ---
>>
>> Turns out this was kind of my fault because I had OVS headers installed
>> on the test system . Those headers obviously had the old macro
>> definitions. So we need to make sure we use the ones from the tree
>> instead.
>>
>
> Do you mean we don't need to bump the sparse version, only ensure the
> tree headers are included?
We need both, sorry for the confusion.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
