On 28 Jan 2022, at 17:04, Adrian Moreno wrote:
> test-odp is used to parse datapath flow actions and matches within the
> odp tests. Wrap calls to this tool in a python script that also parses
> them using the python flow parsing library.
>
> Signed-off-by: Adrian Moreno <amore...@redhat.com>
Changes look good to me.
Acked-by: Eelco Chaudron <echau...@redhat.com>
> ---
> tests/automake.mk | 2 ++
> tests/odp.at | 36 ++++++++++----------
> tests/ovs-test-dpparse.py | 70 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 90 insertions(+), 18 deletions(-)
> create mode 100755 tests/ovs-test-dpparse.py
>
<SNIP>
> diff --git a/tests/ovs-test-dpparse.py b/tests/ovs-test-dpparse.py
> new file mode 100755
> index 000000000..5ccb426c1
> --- /dev/null
> +++ b/tests/ovs-test-dpparse.py
> @@ -0,0 +1,70 @@
> +#!/usr/bin/env python3
Same nit as in the previous patch about removing the full copyright notice.
> +"""
> + ovs-test-dpparse is just a wrapper around ovs-dpctl
> + that also runs the python flow parsing utility to check that flows are
> + parseable.
> +"""
> +import subprocess
> +import sys
> +import re
<SNIP>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
