Peng He <xnhp0...@gmail.com> writes:

> In the commit 1df7f7aac8c976690167261fec9a50d832ef9e7e, the packet
> metadata's in_port has been changed from ofp port into odp port,
> however, the odp->flow->in_port is still ofp_port. This patch changes
> the odp->flow->in_port into odp_port.
>
> Fixes: 1df7f7aac8 ("ofproto-dpif: Restore packet metadata when a
> continuation is resumed.")

This tag is still wrapped, and I don't think the fixes tag is for the
correct commit.

> Signed-off-by: Peng He <hepeng.0...@bytedance.com>
> ---
>  ofproto/ofproto-dpif.c | 1 +

Also, seems there is no unit test as requested.  Can you please address
these?

>  1 file changed, 1 insertion(+)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index cba49a99e..72de67c63 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -4973,6 +4973,7 @@ packet_execute_prepare(struct ofproto *ofproto_,
>      ofproto_dpif_set_packet_odp_port(ofproto, opo->flow->in_port.ofp_port,
>                                       opo->packet);
>  
> +    opo->flow->in_port = opo->packet->md.in_port;
>      ofproto_dpif_packet_out_delete(aux);
>      opo->aux = execute;
>  }

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to