Hi Ihar,
I ran out of time to be reviewing this today, but what I can say is that
patches 1-6: Acked-by: Mark Michelson <[email protected]>
patch 7: I have a small quibble with. See my response on it.
patches 8-9: Acked-by: Mark Michelson <[email protected]>
I had a look at patch 10 but don't want to ack it before looking at the
rest of the series. I'll have a look sometime early next week.
On 2/17/22 10:16, Ihar Hrachyshka wrote:
This version of the series is complete. It contains the previously
missing ddlog implementation; also RARP that is used for additional
chassis activation is now reinjected into the pipeline after blocking
flows are deleted by vswitchd.
Ihar Hrachyshka (16):
tests: log more info on OVN_CHECK_PACKETS* failure
tests: don't bail from OVN_CHECK_PACKETS_CONTAIN prematurily
Introduce chassis_is_vtep
northd: introduce separate function to look up chassis
northd: separate code for nb->sb port binding chassis update
Pass chassis and encap into get_port_binding_tun
Introduce match_outport_dp_and_port_keys in physical.c
Split code to set zone info into put_zones_ofpacts
Use get_port_binding_tun instead of chassis_tunnel_find
Tag all packets that arrived from a tunnel as LOCAL_ONLY
Update port-up on main chassis only
Introduce LSP:options:requested-additional-chassis
Clone packets to both port chassis
Enforce tunneling when additional-chassis is set
Implement RARP activation strategy for ports
Reinject RARP packet when activation-strategy=rarp
---
v0: initial draft (single patch)
v1: split into pieces
v1: renamed options: migration-destination ->
requested-additional-chassis,
migration-unblocked ->
additional-chassis-activated
v1: introduced options:activation-strategy=rarp to allow for other
strategies / having default no-op strategy
v1: implement in-memory port-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v2: added ddlog implementation
v2: re-inject RARP packet after vswitch updates flows
v3: re-sent as a single series
---
controller/binding.c | 188 +++++--
controller/binding.h | 2 +
controller/if-status.c | 15 +-
controller/if-status.h | 1 +
controller/lport.c | 19 +-
controller/ovn-controller.c | 4 +-
controller/physical.c | 390 ++++++++++----
controller/pinctrl.c | 254 ++++++++-
controller/pinctrl.h | 2 +
include/ovn/actions.h | 9 +
lib/actions.c | 40 +-
northd/northd.c | 130 +++--
northd/ovn-northd.c | 7 +-
northd/ovn-sb.dlopts | 2 +
northd/ovn_northd.dl | 169 +++++-
ovn-nb.xml | 18 +
ovn-sb.ovsschema | 17 +-
ovn-sb.xml | 73 ++-
tests/ovn.at | 991 +++++++++++++++++++++++++++++++++++-
utilities/ovn-trace.c | 3 +
20 files changed, 2110 insertions(+), 224 deletions(-)
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
